add [const] PartialEq bound to PartialOrd
#146690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is included for discussion purposes. The PartialOrd bound on PartialEq is not strictly necessary. It is, rather, logical: anything which is orderable should by definition have equality. Is the same true for constness? Should every type which is const orderable also have const equality?
|
I don't have a great answer, but I think this makes sense. If nothing else, it seems more usable: having a type that is Cc @rust-lang/wg-const-eval for thoughts. |
|
we do not elaborate without being involved in any of the design here, i would expect at least a lint that super traits also have to maybe-const for const sub-traits |
This sounds like something that would be helpful. Perhaps just not in cases where the super trait doesn't have any functions, e.g.: pub trait A {
const FOO: u32 = 10;
}
pub const trait B: A {
fn foo() -> u32 { Self::FOO }
}In any case, the change here seems reasonable and looks like it got some 👍 from relevant people, so @bors r+ rollup |
tgross35
approved these changes
Sep 19, 2025
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 19, 2025
add `[const] PartialEq` bound to `PartialOrd` This change is included for discussion purposes. The PartialOrd bound on PartialEq is not strictly necessary. It is, rather, logical: anything which is orderable should by definition have equality. Is the same true for constness? Should every type which is const orderable also have const equality?
This was referenced Sep 19, 2025
bors
added a commit
that referenced
this pull request
Sep 19, 2025
Rollup of 5 pull requests Successful merges: - #146690 (add `[const] PartialEq` bound to `PartialOrd`) - #146776 (fixes for numerous clippy warnings) - #146777 (fix ./x readdir logic when CDPATH is set) - #146781 (mbe: Fix feature gate for `macro_derive`) - #146785 (btree: safety comments for init and new) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 20, 2025
Rollup merge of #146690 - npmccallum:convo, r=tgross35 add `[const] PartialEq` bound to `PartialOrd` This change is included for discussion purposes. The PartialOrd bound on PartialEq is not strictly necessary. It is, rather, logical: anything which is orderable should by definition have equality. Is the same true for constness? Should every type which is const orderable also have const equality?
Muscraft
pushed a commit
to Muscraft/rust
that referenced
this pull request
Sep 24, 2025
add `[const] PartialEq` bound to `PartialOrd` This change is included for discussion purposes. The PartialOrd bound on PartialEq is not strictly necessary. It is, rather, logical: anything which is orderable should by definition have equality. Is the same true for constness? Should every type which is const orderable also have const equality?
Muscraft
pushed a commit
to Muscraft/rust
that referenced
this pull request
Sep 24, 2025
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#146690 (add `[const] PartialEq` bound to `PartialOrd`) - rust-lang#146776 (fixes for numerous clippy warnings) - rust-lang#146777 (fix ./x readdir logic when CDPATH is set) - rust-lang#146781 (mbe: Fix feature gate for `macro_derive`) - rust-lang#146785 (btree: safety comments for init and new) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Oct 9, 2025
add `[const] PartialEq` bound to `PartialOrd` This change is included for discussion purposes. The PartialOrd bound on PartialEq is not strictly necessary. It is, rather, logical: anything which is orderable should by definition have equality. Is the same true for constness? Should every type which is const orderable also have const equality?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestion
2D13
s cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is included for discussion purposes.
The PartialOrd bound on PartialEq is not strictly necessary. It is, rather, logical: anything which is orderable should by definition have equality. Is the same true for constness? Should every type which is const orderable also have const equality?