8000 fix path str eq by bend-n · Pull Request #146194 · rust-lang/rust · GitHub
[go: up one dir, main page]
Skip to content

fix path str eq #146194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2025
Merged

fix path str eq #146194

merged 2 commits into from
Sep 4, 2025

Conversation

bend-n
Copy link
Contributor
@bend-n bend-n commented Sep 4, 2025 •
edited by rustbot
Loading

fixes #146183
where the impl for partialeq for pathbuf resulted in infinite recursion

@rustbot
Copy link
Collaborator
rustbot commented Sep 4, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 4, 2025
fmease
fmease reviewed Sep 4, 2025
View reviewed changes
@fmease
Copy link
Member
fmease commented Sep 4, 2025

cc @Kixunil @Amanieu (#140956)

@ibraheemdev
Copy link
Member

Thanks. @bors r+ rollup

@bors
Copy link
Collaborator
bors commented Sep 4, 2025

📌 Commit 1e37c1f has been approved by ibraheemdev

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 4, 2025
Merged
bors added a commit that referenced this pull request Sep 4, 2025
@bors
Auto merge of #146205 - matthiaskrgr:rollup-fxt43oq, r=matthiaskrgr
0d6a806 
Rollup of 4 pull requests

Successful merges:

 - #145976 (Add bootstrap.toml option to control debug breaking on ICEs on windows)
 - #146151 (fixes auto-run js checks in tidy)
 - #146194 (fix path str eq)
 - #146197 (triagebot: fix rustc_allow_const_fn_unstable matcher)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 60196de into rust-lang:master Sep 4, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 4, 2025
rust-timer added a commit that referenced this pull request Sep 4, 2025
@rust-timer
Unrolled build for #146194
ff54a00 
Rollup merge of #146194 - bend-n:fix-path-str-eq, r=ibraheemdev

fix path str eq

fixes #146183
where the impl for partialeq<str> for pathbuf resulted in infinite recursion
@bend-n bend-n deleted the fix-path-str-eq branch September 4, 2025 19:44
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Sep 9, 2025
@matthiaskrgr
Rollup merge of rust-lang#146194 - bend-n:fix-path-str-eq, r=ibraheemdev
0d0263e 
fix path str eq

fixes rust-lang#146183
where the impl for partialeq<str> for pathbuf resulted in infinite recursion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease left review comments

+1 more reviewer

@gferrate gferrate gferrate approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ibraheemdev ibraheemdev

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.

Checking a &PathBuf and a &str for equality leads to a stack overflow
6 participants
@bend-n @rustbot @fmease @ibraheemdev @bors @gferrate
0