8000 Document representation of `Option<unsafe fn()>` by BennoLossin · Pull Request #141447 · rust-lang/rust · GitHub
[go: up one dir, main page]
Skip to content
  • Topics
    Explore
  • Repositories
  • Available add-ons
  • Pricing

    • Search code, repositories, users, issues, pull requests...

    Provide feedback

    We read every piece of feedback, and take your input very seriously.

    Saved searches

    Use saved searches to filter your results more quickly
    Appearance settings

    Document representation of Option<unsafe fn()> #141447

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Merged
    merged 1 commit into from
    Jun 8, 2025
    Merged

    Document representation of Option<unsafe fn()> #141447

    merged 1 commit into from
    Jun 8, 2025

    Conversation

    BennoLossin
    Copy link
    Contributor

    @rustbot
    Copy link
    Collaborator
    rustbot commented May 23, 2025

    r? @scottmcm

    rustbot has assigned @scottmcm.
    They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

    Use r? to explicitly pick a reviewer

    @rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 23, 2025
    RalfJung
    RalfJung reviewed May 23, 2025
    View reviewed changes
    @RalfJung
    Copy link
    Member
    RalfJung commented May 23, 2025 •
    edited
    Loading

    @rust-lang/lang I assume we can land this without full FCP? unsafe fn vs fn really shouldn't make a difference for the representation.^^

    @RalfJung
    Copy link
    Member

    r? @RalfJung

    @rustbot rustbot assigned RalfJung and unassigned scottmcm May 23, 2025
    @RalfJung
    Copy link
    Member

    @rustbot author

    @rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2025
    @rustbot
    Copy link
    Collaborator
    rustbot commented May 23, 2025

    Reminder, once the PR becomes ready for a review, use @rustbot ready.

    @BennoLossin BennoLossin force-pushed the option-layout-docs branch from 7c0db54 to 69d85e3 Compare May 23, 2025 13:51
    @BennoLossin
    Copy link
    Contributor Author

    @rustbot ready

    @rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 23, 2025
    RalfJung
    RalfJung reviewed May 23, 2025
    View reviewed changes
    @BennoLossin BennoLossin force-pushed the option-layout-docs branch from 69d85e3 to 73013d3 Compare May 23, 2025 13:53
    traviscross
    traviscross reviewed May 23, 2025
    View reviewed changes
    @traviscross traviscross added T-lang Relevant to the language team and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 23, 2025
    @rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2025
    @BennoLossin BennoLossin force-pushed the option-layout-docs branch from 73013d3 to a08f6f1 Compare May 23, 2025 15:38
    @rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 23, 2025
    @traviscross
    Copy link
    Contributor

    @rustbot labels +I-lang-nominated +P-lang-drag-1 +I-lang-easy-decision

    I was tempted to just snap approve this, but I suppose -- obvious though it is -- that it is a new guarantee about the language. Let's do it by FCP but waive the final comment period.

    @rfcbot fcp merge

    @rfcbot
    Copy link
    rfcbot commented May 23, 2025 •
    edited by scottmcm
    Loading

    Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

    No concerns currently listed.

    Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

    cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
    See this document for info about what commands tagged team members can give me.

    @rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label May 28, 2025
    @rfcbot
    Copy link
    rfcbot commented May 28, 2025

    🔔 This is now entering its final comment period, as per the review above. 🔔

    @scottmcm
    Copy link
    Member

    Oh, yup, seems obvious to me.

    @rfcbot reviewed

    @traviscross traviscross removed I-lang-nominated Nominated for discussion during a lang team meeting. I-lang-easy-decision Issue: The decision needed by the team is conjectured to be easy; this does not imply nomination P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang labels May 28, 2025
    @rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jun 7, 2025
    @rfcbot
    Copy link
    rfcbot commented Jun 7, 2025

    The final comment period, with a disposition to merge, as per the review above, is now complete.

    As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

    This will be merged soon.

    @rustbot rustbot mentioned this pull request Jun 7, 2025
    Closed
    @RalfJung
    Copy link
    Member
    RalfJung commented Jun 7, 2025

    @bors r+ rollup

    @bors
    Copy link
    Collaborator
    bors commented Jun 7, 2025

    📌 Commit a08f6f1 has been approved by RalfJung

    It is now in the queue for this repository.

    @bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2025
    workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 7, 2025
    @workingjubilee
    Rollup merge of rust-lang#141447 - y86-dev:option-layout-docs, r=Ralf…
    7a6ea29 
    …Jung

Document representation of `Option<unsafe fn()>`

https://rust-lang.zulipchat.com/#narrow/channel/136281-t-opsem/topic/Option.20Layout.20with.20.60fn.60.20pointers/with/520055652
    @workingjubilee workingjubilee mentioned this pull request Jun 7, 2025
    Closed
    bors added a commit that referenced this pull request Jun 7, 2025
    @bors
    Auto merge of #142175 - workingjubilee:rollup-getk68g, r=workingjubilee
    886cae4 
    Rollup of 14 pull requests

Successful merges:

 - #138062 (Enable Non-determinism of float operations in Miri and change std tests )
 - #140560 (Allow `#![doc(test(attr(..)))]` everywhere)
 - #141001 (Make NonZero<char> possible)
 - #141295 (Stabilize `if let` guards (`feature(if_let_guard)`))
 - #141435 (Add (back) `unsupported_calling_conventions` lint to reject more invalid calling conventions)
 - #141447 (Document representation of `Option<unsafe fn()>`)
 - #142008 (const-eval error: always say in which item the error occurred)
 - #142053 (Add new Tier-3 targets: `loongarch32-unknown-none*`)
 - #142065 (Stabilize `const_eq_ignore_ascii_case`)
 - #142116 (Fix bootstrap tracing imports)
 - #142126 (Treat normalizing consts like normalizing types in deeply normalize)
 - #142140 (compiler: Sort and doc ExternAbi variants)
 - #142148 (compiler: Treat ForceWarning as a Warning for diagnostic level)
 - #142154 (get rid of spurious cfg(bootstrap))

r? `@ghost`
`@rustbot` modify labels: rollup
    GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 7, 2025
    @GuillaumeGomez
    Rollup merge of rust-lang#141447 - y86-dev:option-layout-docs, r=Ralf…
    4d1e42a 
    …Jung

Document representation of `Option<unsafe fn()>`

https://rust-lang.zulipchat.com/#narrow/channel/136281-t-opsem/topic/Option.20Layout.20with.20.60fn.60.20pointers/with/520055652
    This was referenced Jun 7, 2025
    Closed
    Merged
    bors added a commit that referenced this pull request Jun 7, 2025
    @bors
    Auto merge of #142181 - GuillaumeGomez:rollup-pn2p1lu, r=GuillaumeGomez
    67E6
    a5584a8 
    Rollup of 9 pull requests

Successful merges:

 - #140560 (Allow `#![doc(test(attr(..)))]` everywhere)
 - #141447 (Document representation of `Option<unsafe fn()>`)
 - #141661 (Make the `dangerous_implicit_autorefs` lint deny-by-default)
 - #142065 (Stabilize `const_eq_ignore_ascii_case`)
 - #142116 (Fix bootstrap tracing imports)
 - #142126 (Treat normalizing consts like normalizing types in deeply normalize)
 - #142140 (compiler: Sort and doc ExternAbi variants)
 - #142148 (compiler: Treat ForceWarning as a Warning for diagnostic level)
 - #142154 (get rid of spurious cfg(bootstrap))

r? `@ghost`
`@rustbot` modify labels: rollup
    @bors bors merged commit 00db345 into rust-lang:master Jun 8, 2025
    6 checks passed
    @rustbot rustbot added this to the 1.89.0 milestone Jun 8, 2025
    rust-timer added a commit that referenced this pull request Jun 8, 2025
    @rust-timer
    Unrolled build for #141447
    c5fda58 
    Rollup merge of #141447 - y86-dev:option-layout-docs, r=RalfJung

Document representation of `Option<unsafe fn()>`

https://rust-lang.zulipchat.com/#narrow/channel/136281-t-opsem/topic/Option.20Layout.20with.20.60fn.60.20pointers/with/520055652
    lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Jun 9, 2025
    @bors
    Auto merge of #142181 - GuillaumeGomez:rollup-pn2p1lu, r=GuillaumeGomez
    753ad2a 
    Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#140560 (Allow `#![doc(test(attr(..)))]` everywhere)
 - rust-lang/rust#141447 (Document representation of `Option<unsafe fn()>`)
 - rust-lang/rust#141661 (Make the `dangerous_implicit_autorefs` lint deny-by-default)
 - rust-lang/rust#142065 (Stabilize `const_eq_ignore_ascii_case`)
 - rust-lang/rust#142116 (Fix bootstrap tracing imports)
 - rust-lang/rust#142126 (Treat normalizing consts like normalizing types in deeply normalize)
 - rust-lang/rust#142140 (compiler: Sort and doc ExternAbi variants)
 - rust-lang/rust#142148 (compiler: Treat ForceWarning as a Warning for diagnostic level)
 - rust-lang/rust#142154 (get rid of spurious cfg(bootstrap))

r? `@ghost`
`@rustbot` modify labels: rollup
    tautschnig pushed a commit to model-checking/verify-r A3E2 ust-std that referenced this pull request Jun 17, 2025
    @GuillaumeGomez
    Rollup merge of rust-lang#141447 - y86-dev:option-layout-docs, r=Ralf…
    158612f 
    …Jung

Document representation of `Option<unsafe fn()>`

https://rust-lang.zulipchat.com/#narrow/channel/136281-t-opsem/topic/Option.20Layout.20with.20.60fn.60.20pointers/with/520055652
    @apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jun 26, 2025
    @joshlf joshlf mentioned this pull request Jul 1, 2025
    Closed
    @BennoLossin BennoLossin deleted the option-layout-docs branch August 15, 2025 09:18
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @RalfJung RalfJung RalfJung left review comments

    @traviscross traviscross traviscross left review comments

    Assignees

    @RalfJung RalfJung

    Labels
    disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team
    Projects
    None yet
    Milestone
    1.89.0
    Development

    Successfully merging this pull request may close these issues.
    8 participants
    @BennoLossin @rustbot @RalfJung @traviscross @rfcbot @scottmcm @bors @apiraino
    0