8000 Implement `x perf` as a separate tool by Kobzol · Pull Request #127002 · rust-lang/rust · GitHub
[go: up one dir, main page]
Skip to content

Implement x perf as a separate tool #127002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2024
Merged

Implement x perf as a separate tool #127002

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
151986f
Implement `x perf` as a separate tool
Kobzol Jun 27, 2024
f6f21a8
Review changes
Kobzol Jun 29, 2024
6a2638e
Autolabel `rustc-perf-wrapper` changes with t-bootstrap label
Kobzol Jun 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Review changes
  • Loading branch information
@Kobzol
Kobzol committed Jun 29, 2024
commit f6f21a8f11a51336784e93d6ea712f4484d7caef
2 changes: 1 addition & 1 deletion src/bootstrap/src/core/build_steps/perf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Consider setting `rust.debuginfo-level = 1` in `config.toml`."#);
let args = std::env::args().skip_while(|a| a != "--").skip(1);

let mut cmd = builder.tool_cmd(Tool::RustcPerfWrapper);
cmd.env("PERF_RUSTC", rustc)
cmd.env("RUSTC_REAL", rustc)
.env("PERF_COLLECTOR", collector)
.env("PERF_RESULT_DIR", profile_results_dir)
.args(args);
Expand Down
2 changes: 1 addition & 1 deletion src/tools/rustc-perf-wrapper/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# rustc-perf wrapper
Utility tool for invoking [`rustc-perf`](https://github.com/rust-lang/rustc-perf) for benchmarking/profiling
a stage1/2 compiler built by bootstrap using `x run perf`.
a stage1/2 compiler built by bootstrap using `x perf -- <command>`.
2 changes: 1 addition & 1 deletion src/tools/rustc-perf-wrapper/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ struct SharedOpts {
#[derive(Debug, clap::Parser)]
struct BuildContext {
/// Compiler binary that will be benchmarked/profiled.
#[clap(long, hide = true, env = "PERF_RUSTC")]
#[clap(long, hide = true, env = "RUSTC_REAL")]
compiler: PathBuf,
/// rustc-perf collector binary that will be used for running benchmarks/profilers.
#[clap(long, hide = true, env = "PERF_COLLECTOR")]
Expand Down
0