[BETA] revert leak check changes #125629
[BETA] revert leak check changes #125629
Conversation
|
|
r? @rust-lang/types |
This comment has been minimized.
This comment has been minimized.
reverts the behavior changes of rust-lang#119820 to give some additional time to `sqlx` as it is affected by this change.
788e8fb to
62a7694
Compare
|
r=me when it's approved, unless you think my approval is fine on its own. |
|
cc @davidtwco @wesleywiser not sure how to handle types team backports? should we just land them without any additional input or should we also let them go through the compiler team meeting? |
|
We typically review T-types backports during the weekly compiler team triage meeting so we can sign off on it on Thursday (unless there's some reason to approve it sooner than that). |
|
(FWIW, I think the last thing we decided was that T-types can make their own backport decisions, but usually just delegate it back to T-compiler) That being said, I don't care either way about waiting a couple days for this, or just landed this now. This is a pretty cut and dry decision imo. |
|
backport approved https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202024-05-30/near/441466538 can I just use |
Usually beta PRs are backports from master, and someone on the release team will do a pseudo-rollup of several backports at once. But if you're targeting beta only then I think it's fine for you to go ahead with a direct reviewer. (cc @rust-lang/release in case others feel differently) |
|
@bors r+ |
|
@bors rollup=never |
|
☀️ Test successful - checks-actions |
reverts the behavior changes from #119820 to give
sqlxand other affected projects another 6 weeks.Fixes #125194 #126006