8000 Rollup of 4 pull requests by workingjubilee · Pull Request #116501 · rust-lang/rust · GitHub
[go: up one dir, main page]

Skip to content

Rollup of 4 pull requests #116501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 7, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Properly export function defined in test which uses global_asm!()
Currently the test passes with the LLVM backend as the codegen unit
partitioning logic happens to place both the global_asm!() and the
function which calls the function defined by the global_asm!() in the
same CGU. With the Cranelift backend it breaks however as it will place
all assembly in separate codegen units to be passed to an external
linker.
  • Loading branch information
bjorn3 committed Oct 5, 2023
commit 9facf0bf72acf6cbf6ecb6c28c4b5364efc6b83f
9 changes: 8 additions & 1 deletion tests/ui/asm/x86_64/issue-96797.rs
83CA
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,14 @@ use std::arch::global_asm;
#[no_mangle]
fn my_func() {}

global_asm!("call_foobar: jmp {}", sym foobar);
global_asm!("
.globl call_foobar
.type call_foobar,@function
.section .text.call_foobar,\"ax\",@progbits
call_foobar: jmp {}
.size call_foobar, .-call_foobar
.text
", sym foobar);

fn foobar() {}

Expand Down
0