10000 More accurately point to where default return type should go by compiler-errors · Pull Request #116296 · rust-lang/rust · GitHub
[go: up one dir, main page]
Skip to content

More accurately point to where default return type should go #116296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2023
Merged

More accurately point to where default return type should go #116296

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
137b6d0
Point to where missing return type should go
compiler-errors Sep 30, 2023
89b14ae
Fix clippy
compiler-errors Oct 2, 2023
1f079cf
Point to closure return instead of output if defaulted
compiler-errors Oct 2, 2023
dd5f26c
Fix spans for comments in rustfmt
compiler-errors Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix spans for comments in rustfmt
  • Loading branch information
@compiler-errors
compiler-errors committed Oct 4, 2023
commit dd5f26c42dbe24491cc2aae12bca747d1701936c
3 changes: 2 additions & 1 deletion src/tools/rustfmt/src/items.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2599,7 +2599,8 @@ fn rewrite_fn_base(
if where_clause_str.is_empty() {
if let ast::FnRetTy::Default(ret_span) = fd.output {
match recover_missing_comment_in_span(
mk_sp(params_span.hi(), ret_span.hi()),
// from after the closing paren to right before block or semicolon
mk_sp(ret_span.lo(), span.hi()),
shape,
context,
last_line_width(&result),
Expand Down
0