8000 Improve `File::set_times` error handling by beetrees · Pull Request #101675 · rust-lang/rust · GitHub
[go: up one dir, main page]
Skip to content

Improve File::set_times error handling #101675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2022
Merged

Improve File::set_times error handling #101675

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39c0b00
Error instead of panicking when setting file times if the passed `Sys…
beetrees Sep 10, 2022
c66860a
`SetFileTime` doesn't allow setting the file time to `0xFFFF_FFFF_FFF…
beetrees Sep 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
SetFileTime doesn't allow setting the file time to `0xFFFF_FFFF_FFF… 
…F_FFFF`
  • Loading branch information
@beetrees
beetrees committed Oct 1, 2022
commit c66860ab3ed7861458fca2fba4a7e5f512571537
8 changes: 8 additions & 0 deletions library/std/src/sys/windows/fs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +57 6AEF 2,14 @@ impl File {
"Cannot set file timestamp to 0",
));
}
let is_max =
|t: c::FILETIME| t.dwLowDateTime == c::DWORD::MAX && t.dwHighDateTime == c::DWORD::MAX;
if times.accessed.map_or(false, is_max) || times.modified.map_or(false, is_max) {
return Err(io::const_io_error!(
io::ErrorKind::InvalidInput,
"Cannot set file timestamp to 0xFFFF_FFFF_FFFF_FFFF",
));
}
cvt(unsafe {
c::SetFileTime(self.as_handle(), None, times.accessed.as_ref(), times.modified.as_ref())
})?;
Expand Down
0