Ban references to Self in trait object substs for projection predicates too.
#100500
+67
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcnr
reviewed
Aug 13, 2022
| // Like for trait refs, verify that `dummy_self` did not leak inside default type | ||
| // parameters. | ||
| let references_self = b.projection_ty.substs.iter().skip(1).any(|arg| { | ||
| if let ty::GenericArgKind::Type(ty) = arg.unpack() { |
There was a problem hiding this comment.
this feels incorrect for const generics. What happens if you have a generic constant referencing self? (using feature(generic_const_exprs))
a generic constant not using self would be even worse 😅 because it still has Self in its generic arguments even if unused.
There was a problem hiding this comment.
were there any problems with using arg.walk instead of ty.walk. Also, the generic arg itself should get returned as the first item of walk, so the explicit ty == dummy_self check shouldn't be necessary
There was a problem hiding this comment.
Do you have a test in mind for this?
There was a problem hiding this comment.
use feature(generic_const_exprs) and have a Trait<{ N + 1 } in it, or even Trait<{ 1 + 2 }>.
can look into making a full example if you want, am done for today 😅
|
@bors r+ |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 20, 2022
…lcnr Ban references to `Self` in trait object substs for projection predicates too. Fixes rust-lang#100484 Fixes rust-lang#100485 r? `@lcnr`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 20, 2022
…lcnr Ban references to `Self` in trait object substs for projection predicates too. Fixes rust-lang#100484 Fixes rust-lang#100485 r? ``@lcnr``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 20, 2022
…lcnr Ban references to `Self` in trait object substs for projection predicates too. Fixes rust-lang#100484 Fixes rust-lang#100485 r? ```@lcnr```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 20, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#97963 (net listen backlog set to negative on Linux.) - rust-lang#99935 (Reenable disabled early syntax gates as future-incompatibility lints) - rust-lang#100129 (add miri-test-libstd support to libstd) - rust-lang#100500 (Ban references to `Self` in trait object substs for projection predicates too.) - rust-lang#100636 (Revert "Revert "Allow dynamic linking for iOS/tvOS targets."") - rust-lang#100718 ([rustdoc] Fix item info display) - rust-lang#100769 (Suggest adding a reference to a trait assoc item) - rust-lang#100777 (elaborate how revisions work with FileCheck stuff in src/test/codegen) - rust-lang#100796 (Refactor: remove unnecessary string searchings) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100484
Fixes #100485
r? @lcnr