8000 fix content-type for zstd files, additionally build & serve gzip compressed rustdoc json by syphar · Pull Request #2848 · rust-lang/docs.rs · GitHub
[go: up one dir, main page]
Skip to content

fix content-type for zstd files, additionally build & serve gzip compressed rustdoc json #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

fix content-type for zstd files, additionally build & serve gzip compressed rustdoc json #2848

merged 1 commit into from
Jun 22, 2025

Conversation

syphar
Copy link
Member
@syphar syphar commented Jun 22, 2025
  • we previously did set the wrong content type for the zstd file , that's fixed
  • I needed a storage method to upload without compression, so I can compress myself before uploading
  • I also don't want Content-Encoding to be set, so the files are offered as downloads, not rendered in the browser

Apart from that, most of the code is:

  • adding gzip compression
  • additionally building & storing gzip
  • supporting a .zst or .gz suffix on the URLs.
  • still supporting a fallback to the old files we have built until now.

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jun 22, 2025
@syphar syphar marked this pull request as ready for review June 22, 2025 11:19
@syphar syphar requested a review from a team as a code owner June 22, 2025 11:19
GuillaumeGomez
GuillaumeGomez reviewed Jun 22, 2025
View reviewed changes
@syphar syphar merged commit ff5ebf0 into rust-lang:master Jun 22, 2025
15 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jun 22, 2025
@syphar syphar deleted the gzip-json branch June 22, 2025 17:56
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syphar @GuillaumeGomez
0