8000 Replace yank button with a drop down menu by eth3lbert · Pull Request #11366 · rust-lang/crates.io · GitHub
[go: up one dir, main page]
Skip to content

Replace yank button with a drop down menu #11366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 18, 2025
Merged

Replace yank button with a drop down menu #11366

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f2edee4
VersionList::Row: Replace yank button with a dropdown menu
eth3lbert Jun 15, 2025
afcf659
VersionList::Row: Only show the actions menu to the privileged user
eth3lbert Jun 15, 2025
45a4066
VersionList::Row: Increase dropdown icon size
Turbo87 Jun 18, 2025
514bb14
VersionList::Row: Deemphasize dropdown trigger icon and add hover effect
Turbo87 Jun 18, 2025
b789ca1
VersionList::Row: Remove nested `PrivilegedAction`
Turbo87 Jun 18, 2025
76bbb55
PrivilegedAction: Update root elements to accept additional attributes
Turbo87 Jun 18, 2025
4ba7e47
VersionList::Row: Fix font size
Turbo87 Jun 18, 2025
249b7cb
VersionList::Row: Center the dropdown trigger vertically
Turbo87 Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
VersionList::Row: Center the dropdown trigger vertically
  • Loading branch information
@Turbo87
Turbo87 committed Jun 18, 2025
commit 249b7cb1db270c53902d61cbdaed6b227fc1affb
2 changes: 1 addition & 1 deletion app/components/version-list/row.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
{{/if}}
</div>

<PrivilegedAction @userAuthorised={{this.isOwner}}>
<PrivilegedAction @userAuthorised={{this.isOwner}} local-class="actions">
<Dropdown local-class="dropdown" data-test-actions-menu as |dd|>
<dd.Trigger @hideArrow={{true}} local-class="trigger" data-test-actions-toggle>
{{svg-jar "ellipsis-circle" local-class="icon"}}
Expand Down
6 changes: 6 additions & 0 deletions app/components/version-list/row.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,12 @@
margin-top: var(--space-2xs);
}

.actions {
display: flex;
}

.dropdown {
display: flex;
font-size: initial;
line-height: 1rem;
}
Expand All @@ -260,6 +265,7 @@
}

.menu {
top: 100%;
right: 0;
min-width: max-content;
}
Expand Down
Loading
0