Allow empty and Bearer auth schemes in Authorization headers
#11350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e7b3cb4 to
2829fb1
Compare
eth3lbert
approved these changes
Jun 14, 2025
There was a problem hiding this comment.
Yeah, I just checked that there's even an open issue in cargo about the auth scheme. But anyway, this LGTM. I just left a small nit. Maybe we also want to add some comments in the codebase, even linking to issues, to provide context and explain why we need to support this.
... by using the new `AuthHeader` extractor, which also slightly improves our error messages.
... by using the new `AuthHeader` extractor, which also slightly improves our error messages.
All of our users at this point have `&str` anyway, so we might as well operate on strings.
2829fb1 to
cd28aa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo publishwas built without using an auth scheme in theAuthorizationheader. Regular HTTP client libraries often only support either basic or bearer authentication, but not empty auth schemes.The regular API tokens currently only support an empty auth scheme, while Trusted Publishing was (mistakenly) built in a way to only support the
Bearerauth scheme.This PR adjusts both code paths to use a shared
Authorizationheader extractor which allows usage of an empty auth scheme, or theBearerauth scheme, regardless of the type of token that is used or the API endpoint it is used on.Related:
Bearerauth scheme #11347