8000 libm: Run benchmarks on aarch64 as well as x86-64 by tgross35 · Pull Request #930 · rust-lang/compiler-builtins · GitHub
[go: up one dir, main page]
Skip to content

libm: Run benchmarks on aarch64 as well as x86-64 #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

libm: Run benchmarks on aarch64 as well as x86-64 #930

wants to merge 1 commit into from
+39 −8

Conversation

tgross35
Copy link
Contributor

No description provided.

@tgross35 tgross35 marked this pull request as ready for review May 29, 2025 19:38
@tgross35
Copy link
Contributor Author

There must be a quiet error accessing perf counters or something. On CI results are looking like this:

icount::icount_bench_acos_group::icount_bench_acos logspace:setup_acos()
  Baselines:                      softfloat|softfloat
  Instructions:                          42|N/A                  (*********)
  L1 Hits:                               50|N/A                  (*********)
  L2 Hits:                                1|N/A                  (*********)
  RAM Hits:                               8|N/A                  (*********)
  Total read+write:                      59|N/A                  (*********)
  Estimated Cycles:                     335|N/A                  (*********)

But locally, something like this should be more accurate:

icount::icount_bench_acos_group::icount_bench_acos logspace:setup_acos()
  Instructions:                       11705|N/A                  (*********)
  L1 Hits:                            13028|N/A                  (*********)
  L2 Hits:                                1|N/A                  (*********)
  RAM Hits:                              17|N/A                  (*********)
  Total read+write:                   13046|N/A                  (*********)
  Estimated Cycles:                   13628|N/A                  (*********)

@tgross35
Copy link
Contributor Author

I don't think this will work, maybe in qemu.

@tgross35 tgross35 closed this May 29, 2025
@tgross35 tgross35 deleted the aarch64-bench branch May 29, 2025 19:51
@tgross35
Copy link
Contributor Author

Turned some of this into #933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tgross35
0