8000 Increase the benchmark rustc version to 2025-05-28 by tgross35 · Pull Request #928 · rust-lang/compiler-builtins · GitHub
[go: up one dir, main page]
Skip to content

Increase the benchmark rustc version to 2025-05-28 #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

Increase the benchmark rustc version to 2025-05-28 #928

merged 1 commit into from
May 29, 2025

Conversation

tgross35
Copy link
Contributor
@tgross35 tgross35 commented May 29, 2025 •
edited
Loading

We may soon want to use some new nightly features in compiler-builtins
and libm, specifically cfg_target_has_reliable_f16_f128 which was
added in the past few weeks. This will mean we need a newer toolchain
for benchmarks to continue building.

Bump to the current latest nightly so we are not blocked on this down
the line.

ci: allow-regressions

@tgross35 tgross35 force-pushed the increase-benchmark-rust-version branch from 91258f7 to de2fee1 Compare May 29, 2025 18:58
@tgross35
Increase the benchmark rustc version to 2025-05-28
7f37311 
We may soon want to use some new nightly features in `compiler-builtins`
and `libm`, specifically `cfg_target_has_reliable_f16_f128` which was
added in the past few weeks. This will mean we need a newer toolchain
for benchmarks to continue building.

Bump to the current latest nightly so we are not blocked on this down
the line.
@tgross35 tgross35 force-pushed the increase-benchmark-rust-version branch from de2fee1 to 7f37311 Compare May 29, 2025 19:57
@tgross35 tgross35 marked this pull request as ready for review May 29, 2025 19:57
@tgross35
Copy link
Contributor Author

Pretty uniform 1-5% improvements across the board since this comes with an LLVM version bump. E.g.

count::icount_bench_copysign_group::icount_bench_copysign logspace:setup_copysign()
  Baselines:                      softfloat|softfloat
  Instructions:                        5492|7607                 (-27.8033%) [-1.38511x]
  L1 Hits:                             8755|10868                (-19.4424%) [-1.24135x]
  L2 Hits:                                2|3                    (-33.3333%) [-1.50000x]
  RAM Hits:                               5|6                    (-16.6667%) [-1.20000x]
  Total read+write:                    8762|10877                (-19.4447%) [-1.24138x]
  Estimated Cycles:                    8940|11093                (-19.4086%) [-1.24083x]
icount::icount_bench_fma_group::icount_bench_fma logspace:setup_fma()
  Baselines:                      softfloat|softfloat
  Instructions:                       51204|53426                (-4.15902%) [-1.04340x]
  L1 Hits:                            57968|60188                (-3.68844%) [-1.03830x]
  L2 Hits:                                4|6                    (-33.3333%) [-1.50000x]
  RAM Hits:                              19|19                   (No change)
  Total read+write:                   57991|60213                (-3.69023%) [-1.03832x]
  Estimated Cycles:                   58653|60883                (-3.66276%) [-1.03802x]

@tgross35
Copy link
Contributor Author

The copysign difference, for my own curiosity.

.section .text.libm::math::copysign::copysign,"ax",@progbits
        .globl  libm::math::copysign::copysign
        .p2align        4, 0x90
.type   libm::math::copysign::copysign,@function
libm::math::copysign::copysign:
        .cfi_startproc
        andps xmm0, xmmword ptr [rip + .LCPI27_0]
        movsd xmm2, qword ptr [rip + .LCPI27_1]
        andps xmm2, xmm1
        orps xmm0, xmm2
        ret
.section .text.libm::math::copysign::copysign,"ax",@progbits
        .globl  libm::math::copysign::copysign
        .p2align        4
.type   libm::math::copysign::copysign,@function
libm::math::copysign::copysign:
        .cfi_startproc
        andps xmm1, xmmword ptr [rip + .LCPI27_0]
        andps xmm0, xmmword ptr [rip + .LCPI27_1]
        orps xmm0, xmm1
        ret

@tgross35 tgross35 merged commit 7f37311 into rust-lang:master May 29, 2025
35 checks passed
@tgross35 tgross35 deleted the increase-benchmark-rust-version branch May 29, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tgross35
0