8000 docs: move docs building process to contributor guide by weihanglo · Pull Request #15854 · rust-lang/cargo · GitHub
[go: up one dir, main page]

Skip to content

Conversation

weihanglo
Copy link
Member
@weihanglo weihanglo commented Aug 17, 2025

What does this PR try to resolve?

Pull https://github.com/rust-lang/cargo/blob/71eb84f21aef43c07580c6aed6f806a6299f5042/src/doc/README.md into our contributor guide for visibility.

Also a writing guideline is added to the chapter, as well as some minor polish.

This is created after seeing the contributing frictions in #15838 (comment).

How to test and review this PR?

mdbook serve src/doc/contrib

@rustbot
Copy link
Collaborator
rustbot commented Aug 17, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2025
@weihanglo
Copy link
Member Author

cc @zdivelbiss if you have any other suggestion to this guide.

@weihanglo weihanglo changed the title docs(contrib): move docs building process to contributor guide docs: move docs building process to contributor guide Aug 18, 2025
Comment on lines 60 to 65
The templates are located in
<https://github.com/rust-lang/cargo/tree/master/src/doc/man>
and are converted into three formats:

The templates are located in <https://github.com/rust-lang/cargo/tree/master/src/doc/man>
and are converted into three formats:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines are duplicated (probably unintentionally?).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Fixed!

@zdivelbiss
Copy link
Contributor
zdivelbiss commented Aug 18, 2025

This looks great! I hadn't known this existed (I have a keen eye when it comes to subconsciously skipping over important documents lol). Hopefully adding it to the contribution guide will help others, too.

Comment on lines 64 to 66
1. Troff man pages --- used by the `cargo help` command,
saved in <https://github.com/rust-lang/cargo/tree/master/src/etc/man>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are also used by distributions to provide man pages which they can install. In the pre-built versions we provide, they are located in $SYSROOT/share/man/man1. (Controlled with the install.mandir bootstrap config option.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Let me know if it is still not good enough.

Copy link
Contributor
@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.

@ehuss ehuss added this pull request to the merge queue Sep 11, 2025
Merged via the queue into rust-lang:master with commit 7470eb0 Sep 12, 2025
23 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 12, 2025
bors added a commit to rust-lang/rust that referenced this pull request Sep 17, 2025
Update cargo submodule

19 commits in 24bb93c388fb8c211a37986539f24a819dc669d3..966f94733bbc94ca51ff9f1e4c49ad250ebbdc50
2025-09-10 23:16:07 +0000 to 2025-09-16 17:24:45 +0000
- fix(frontmatter): Improve error quality (rust-lang/cargo#15972)
- fix: wrong variable name in documentation (rust-lang/cargo#15968)
- Add "Optimizing Build Performance" section to the Cargo book (rust-lang/cargo#15924)
- Remove extra apostrophe in environment-variables.md (rust-lang/cargo#15963)
- Clarify warning for using `features` or `default-features` in `patch` (rust-lang/cargo#15953)
- fix(frontmatter): Try alternative len code fences (rust-lang/cargo#15952)
- feat(cli): Allow completions for third-party subcommand names (rust-lang/cargo#15961)
- docs(index): Clarify what we mean by omitting features (rust-lang/cargo#15957)
- fix(future): Report all content as a single Report (rust-lang/cargo#15943)
- fix(complete): Show local crates/features over other members  (rust-lang/cargo#15956)
- docs(resolver): Describe the role of the lockfile  (rust-lang/cargo#15958)
- chore: Skip check-version-bump ci job in forks (rust-lang/cargo#15959)
- Eliminate the last three "did you mean" warning phrasings (rust-lang/cargo#15356)
- fix(info): Suggest a more universal `cargo tree` command (rust-lang/cargo#15954)
- feat(cli): Use ellipses when truncating progress (rust-lang/cargo#15955)
- feat(completer): Added completion for `--features` flag (rust-lang/cargo#15309)
- fix(publish): Switch the 'ctrl-c on wait' line to a help message (rust-lang/cargo#15942)
- docs: move docs building process to contributor guide (rust-lang/cargo#15854)
- fix(manifest): Show error source to users (rust-lang/cargo#15939)

r? ghost
@rustbot rustbot added this to the 1.92.0 milestone Sep 17, 2025
@weihanglo weihanglo deleted the doc branch October 6, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0