fix: Take Into<Cow> instead of &str #232

Muscraft · 2025-06-27T20:18:56Z

Fixes #200

src/snippet.rs

src/level.rs

epage · 2025-06-27T21:38:45Z

tests/formatter.rs

@@ -2448,7 +2448,7 @@ fn secondary_title_no_level_text() {
        )
        .element(
            Level::NOTE
-                .text(None)
+                .text(None::<&str>)


Is this still needed?

How come and then why does OptionCow exist? I thought it was to bypass this problem

::<&str> is needed because the type of None can't be inferred, as the From impl for Option is generic over T: Into<Cow<'a, str>>. This problem would still exist if we were to write out the different From.

OptionCow exists to solve the more common case of passing in a literal without also needing to write Some().

Muscraft force-pushed the use-cow branch from e7a07a4 to a1ed0a9 Compare June 27, 2025 20:19

Muscraft changed the title ~~fix: Take Cow instead of &str~~ fix: Take Into<Cow> instead of &str Jun 27, 2025

epage reviewed Jun 27, 2025

View reviewed changes

src/snippet.rs Outdated Show resolved Hide resolved

epage reviewed Jun 27, 2025

View reviewed changes

src/level.rs Outdated Show resolved Hide resolved

Muscraft force-pushed the use-cow branch from a1ed0a9 to d058e8a Compare June 27, 2025 21:18

epage reviewed Jun 27, 2025

View reviewed changes

fix: Take Into<Cow> instead of &str

37542ef

Muscraft force-pushed the use-cow branch from d058e8a to 37542ef Compare June 27, 2025 22:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Take Into<Cow> instead of &str #232

fix: Take Into<Cow> instead of &str #232

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix: Take Into<Cow> instead of &str #232

Are you sure you want to change the base?

fix: Take Into<Cow> instead of &str #232

Conversation

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!