N23: backroll-rs 10000 and GGRS #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think going over the character limit is fine here, due to the combo of:
- Multiple projects being covered
- The projects being mentioned for the first time and needing some background info
Only issue I can spot is the line length - the linter (which hasn't run yet, due to GitHub locking down CI for new contributors...) will complain if any line is above 80 characters. Could you add line breaks to resolve this? Happy to approve once that's done.
|
I took care of the line length issue and slightly changed a single sentence to be more precise in regard to the author's recommendations. |
17cupsofcoffee
approved these changes
Jul 2, 2021
james7132
suggested changes
Jul 3, 2021
|
@ValorZard could you take a look at the backroll-rs part of the PR, please? |
ozkriff
approved these changes
Jul 5, 2021
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #677
backroll-rs and GGRS collaborated in a joint section. The section exceeds 1000 characters, but not 2000 characters. Since we are writing for two new libraries, I hope this is okay.