8000 N21: puffin_egui by emilk · Pull Request #615 · rust-gamedev/rust-gamedev.github.io · GitHub
[go: up one dir, main page]
Skip to content

N21: puffin_egui #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2021
Merged

N21: puffin_egui #615

merged 2 commits into from
May 6, 2021

Conversation

emilk
Copy link
Contributor
@emilk emilk commented May 6, 2021

Part of #589

Sorry for the late submission!

@emilk
N21: puffin_egui
9ccb594 
Part of rust-gamedev#589

Sorry for the late submission!
17cupsofcoffee
17cupsofcoffee requested changes May 6, 2021
View reviewed changes
Copy link
Collaborator
@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good, but the GIF is a bit too big (we usually aim for a maximum of 2.5mb, but the lower the better really) - could you replace it with something smaller?

Here's a lower framerate version of your current GIF, if you want to use it:

ezgif-7-38e9c0ac7145

@emilk
Copy link
Contributor Author
emilk commented May 6, 2021

Thanks for the low framerate gif!

@17cupsofcoffee 17cupsofcoffee merged commit 7ef78de into rust-gamedev:source May 6, 2021
@17cupsofcoffee
Copy link
Collaborator

Thank you for the PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @17cupsofcoffee
0