8000 Convert Function::call (and related) to take GuardedArgs instead of Args by dstoza · Pull Request #715 · rune-rs/rune · GitHub
[go: up one dir, main page]
Skip to content

Convert Function::call (and related) to take GuardedArgs instead of Args #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 11, 2024
Merged

Convert Function::call (and related) to take GuardedArgs instead of Args #715

merged 10 commits into from
Oct 11, 2024

Conversation

dstoza
Copy link
Contributor
@dstoza dstoza commented Jun 20, 2024

No description provided.

@dstoza dstoza marked this pull request as ready for review June 20, 2024 20:43
udoprog
udoprog approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator
@udoprog udoprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me with one comment, thank you!

@udoprog udoprog added the enhancement New feature or request label Jun 21, 2024
@dstoza dstoza force-pushed the stoza/functions-take-guardedargs branch from 8588a56 to 47b5b30 Compare October 1, 2024 18:00
dstoza
dstoza commented Oct 2, 2024
View reviewed changes
@dstoza
Copy link
Contributor Author
dstoza commented Oct 2, 2024

Okay, now that I actually understand your point, I think I've fixed this correctly: Function::call still takes GuardedArgs, but rather than uselessly returning TupleVariant/TupleStructs with internal references that can't (and shouldn't) be accessed, it returns an error.

@dstoza dstoza force-pushed the stoza/functions-take-guardedargs branch from 6d7f604 to 80497a9 Compare October 10, 2024 20:26
udoprog
udoprog reviewed Oct 10, 2024
View reviewed changes
@udoprog
Copy link
Collaborator
udoprog commented Oct 11, 2024

Cool, thank you!

@udoprog udoprog merged commit 3726f5f into rune-rs:main Oct 11, 2024
23 checks passed
@dstoza dstoza deleted the stoza/functions-take-guardedargs branch November 6, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udoprog udoprog udoprog approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstoza @udoprog
0