8000 rune_modules 0.13.3: Incorrect dependencies between features · Issue #734 · rune-rs/rune · GitHub
[go: up one dir, main page]
Skip to content

rune_modules 0.13.3: Incorrect dependencies between features #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
VorpalBlade opened this issue Jul 15, 2024 · 0 comments · Fixed by #738
Closed

rune_modules 0.13.3: Incorrect dependencies between features #734

VorpalBlade opened this issue Jul 15, 2024 · 0 comments · Fixed by #738

Comments

@VorpalBlade
Copy link
Contributor 
$ cargo new dummy
$ cd dummy
$ cargo add rune_modules --features=process
$ cargo build
[...]
   Compiling rune-modules v0.13.3
error[E0432]: unresolved import `tokio`
  --> /home/arvid/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rune-modules-0.13.3/src/process.rs:38:5
   |
38 | use tokio::process;
   |     ^^^^^ use of undeclared crate or module `tokio`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `rune-modules` (lib) due to 1 previous error

Seems that the process feature should depend on the tokio feature.

Also, does this mean I can't use smol as my runtime instead of tokio if I want to use the process module?
VorpalBlade added a commit to VorpalBlade/rune that referenced this issue Jul 16, 2024
@VorpalBlade
rune_modules: Add missing dependency on tokio from the process feature (
3e6bbe0 
fixes rune-rs#734)
@VorpalBlade VorpalBlade mentioned this issue Jul 16, 2024
Merged
VorpalBlade added a commit to VorpalBlade/rune that referenced this issue Jul 16, 2024
@VorpalBlade
rune_modules: Add missing dependency on tokio from the process feature (
8e23771 
fixes rune-rs#734)
VorpalBlade added a commit to V 7DA4 orpalBlade/rune that referenced this issue Jul 16, 2024
@VorpalBlade
rune_modules: Add missing dependency on tokio from the process feature (
59f7321 
fixes rune-rs#734)
udoprog pushed a commit that referenced this issue Jul 16, 2024
@VorpalBlade
modules: Add missing dependency on tokio from the process feature (fixes
1cfccc8 
 #734) (#738)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rune_modules: Add missing dependency on tokio from the process feature (fixes #734) VorpalBlade/rune
1 participant
@VorpalBlade
0