Parallel func calling cleanup work #8808
Merged
+145
−156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd701c7 to
8f1184b
Compare
nerdai
commented
Nov 9, 2023
nerdai
commented
Nov 9, 2023
|
|
||
| # update using deltas | ||
| role = delta.role or MessageRole.ASSISTANT | ||
| content_delta = delta.content or "" | ||
| content += content_delta | ||
|
|
||
| # TODO: REFACTOR WITH FUNCTIONS | ||
| # openai provides the delta on one tool-at-a-time |
There was a problem hiding this comment.
@jerryjliu's 1st comment from yesterdays PR:
high-level this is a lot of nested code, can we abstract out into helper functions above?
jerryjliu's 2nd comment
same with the async version
nerdai
commented
Nov 9, 2023
| @@ -42,7 +42,10 @@ def to_openai_function(self) -> Dict[str, Any]: | |||
| The name and arguments of a function that should be called, as generated by the | |||
| model. | |||
| """ | |||
| # TODO fix this and make sure nothing breaks | |||
| return self.to_openai_tool() | |||
There was a problem hiding this comment.
@jerryjliu Comment on this from original PR
is this just duplicate code with to_openai_function? Can we just have to_openai_function call to_openai_tool while still marking it as deprecated?
ryanpeach
pushed a commit
to OnScale/llama_index
that referenced
this pull request
Feb 7, 2024
* have to_openai_function just call to_openai_tool * wip * wip * wip * delegate check if tool_calls_delta is None to helper * refactor _astream_chat * wip * use typed objects over dicts, chat and achat * get streaming to work * add type checking of tool_call * remove Any * fix missing self * update openai_program * resolving mypy issues in python3.9 * resolving mypy issues in python3.9 * wip * update doc string for _update_tool_calls helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR completes the hangover work from the original parallel function PR #8738. In particular, the items that were marked as TODO which came from @jerryjliu's and @Disiok have been completed:
_stream_chatand_astream_chatthru cleaner logic and with helper functiondicts when dealing withtool_callto_openai_functionnow invokesto_openai_toolto_openai_functionto prepare theirtoolsFor convenience, I have added comments in the places where @jerryjliu and @Disiok raised comments in the original PR (#8738)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration