Fix restore options consistency. #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have submitted this as a PR, rather than just merging it, as it is a change in defaults, etc. |
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 5, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 5, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 5, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 5, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 5, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 5, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 5, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 5, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 5, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 5, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 5, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 5, 2021
This reverts commit 2b16077.
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 5, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 5, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 6, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 6, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 6, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 6, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 6, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 6, 2021
hainesr
pushed a commit
that referenced
this pull request
Jun 6, 2021
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 6, 2021
This reverts commit 6ac2cb2.
jspanjers
added a commit
to jspanjers/rubyzip
that referenced
this pull request
Jun 6, 2021
This reverts commit 6ac2cb2.
This will ensure consistency between `File` and `Entry`.
Was only being done on Unix-type filesystems for some reason. Moved code so that it is run for all files, whatever the underlying platform.
6436bbe to
3ca6c7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now.
2B9B
Please check back later.
This PR is, finally, to finish off the work to fix and make consistent the options to restore file timestamps and file permissions on extraction.
The default options are now specified at the top level so that both
FileandEntryget a consistent view of them. They can still be overridden per-File- and per-Entryif needs be.Additionally this PR enables timestamps to be restored on Windows.
This PR closes #422 and fixes #336.