Fix Style/TernaryParentheses cop.

rubyzip · jdleesmiller · Feb 16, 2020 · Sep 14, 2019 · Sep 15, 2019 · Feb 8, 2020
commit d07b36b2e63b2b51feb0a935fe7e7c4bb169c1c3
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -168,15 +168,6 @@ Style/SafeNavigation:
     - 'test/filesystem/file_nonmutating_test.rb'
     - 'test/filesystem/file_stat_test.rb'
     - 'test/test_helper.rb'
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, AllowSafeAssignment.
-# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
-Style/TernaryParentheses:
-  Exclude:
-    - 'lib/zip/crypto/decrypted_io.rb'
-    - 'lib/zip/inflater.rb'
-    - 'lib/zip/pass_thru_decompressor.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.

diff --git a/lib/zip/crypto/decrypted_io.rb b/lib/zip/crypto/decrypted_io.rb
@@ -8,7 +8,7 @@ def initialize(io, decrypter)
     end
 
     def read(length = nil, outbuf = +'')
-      return ((length.nil? || length.zero?) ? '' : nil) if eof
+      return (length.nil? || length.zero? ? '' : nil) if eof
 
       while length.nil? || (buffer.bytesize < length)
         break if input_finished?

diff --git a/lib/zip/inflater.rb b/lib/zip/inflater.rb
@@ -8,7 +8,7 @@ def initialize(*args)
     end
 
     def read(length = nil, outbuf = '')
-      return ((length.nil? || length.zero?) ? '' : nil) if eof
+      return (length.nil? || length.zero? ? '' : nil) if eof
 
       while length.nil? || (@buffer.bytesize < length)
         break if input_finished?

diff --git a/lib/zip/pass_thru_decompressor.rb b/lib/zip/pass_thru_decompressor.rb
@@ -6,7 +6,7 @@ def initialize(*args)
     end
 
     def read(length = nil, outbuf = '')
-      return ((length.nil? || length.zero?) ? '' : nil) if eof
+      return (length.nil? || length.zero? ? '' : nil) if eof
 
       if length.nil? || (@read_so_far + length) > decompressed_size
         length = decompressed_size - @read_so_far