8000 Sync options and fix inconsistent behaviour of `Zip::File#get_entry` and `Zip::File#find_entry`. by hainesr · Pull Request #423 · rubyzip/rubyzip · GitHub
[go: up one dir, main page]
Skip to content

Sync options and fix inconsistent behaviour of Zip::File#get_entry and Zip::File#find_entry. #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 15, 2019
Merged

Sync options and fix inconsistent behaviour of Zip::File#get_entry and Zip::File#find_entry. #423

merged 4 commits into from
Dec 15, 2019

Conversation

hainesr
Copy link
Member
@hainesr hainesr commented Oct 31, 2019

See #422 for a detailed explanation of what is going on here.

This is the quick fix to ensure things are consistent for now. I will work up a PR with a longer term fix once we've decided what to do about it.

@coveralls
Copy link
coveralls commented Oct 31, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 95.459% when pulling f3a2f4a on hainesr:sync-options into 6389d65 on rubyzip:master.

jdleesmiller
jdleesmiller approved these changes Dec 15, 2019
View reviewed changes
Copy link
Member
@jdleesmiller jdleesmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdleesmiller
Copy link
Member

(I looked back in the blame, and it seems like this inconsistency has always been here, but I don't see any rationale for the current behavior.)

@jdleesmiller jdleesmiller merged commit c925bdb into rubyzip:master Dec 15, 2019
jdleesmiller added a commit that referenced this pull request Dec 15, 2019
@jdleesmiller
Update changelog for #423
d3027ea
@hainesr hainesr deleted the sync-options branch December 15, 2019 21:31
This was referenced Mar 11, 2021
Closed
Merged
Merged
Closed
Open
Closed
Open
Open
Closed
Closed
Merged
Closed
Open
Open
Open
Open
Merged
Merged
Open
Open
This was referenced Mar 17, 2021
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdleesmiller jdleesmiller jdleesmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hainesr @coveralls @jdleesmiller
0