Add --target-rbconfig option to gem install and gem update commands
#7628
+199
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57df8bd to
97fa3ff
Compare
394788b to
7868c67
Compare
86a8474 to
132178c
Compare
| require "tempfile" | ||
| require "fileutils" | ||
|
|
||
| if target_rbconfig.path | ||
| warn "--target-rbconfig is not yet supported for Rust extensions. Ignoring" |
There was a problem hiding this comment.
what would it take to implement this for rust?
There was a problem hiding this comment.
Basically, it should be done by replacing RbConfig reference with the corresponding value of target_rbconfig in cargo_builder.rb. Maybe we need some change in rb-sys side, but wouldn't be big.
hsbt
reviewed
Jun 17, 2024
bundler/lib/bundler/cli/install.rb
Outdated
| @@ -19,6 +19,10 @@ def run | |||
| # Disable color in deployment mode | |||
| Bundler.ui.shell = Thor::Shell::Basic.new if options[:deployment] | |||
|
|
|||
| if target_rbconfig_path = options["target-rbconfig"] | |||
There was a problem hiding this comment.
Suggested change
| if target_rbconfig_path = options["target-rbconfig"] | |
| if target_rbconfig_path = options[:target-rbconfig] |
|
After resolving https://github.com/rubygems/rubygems/pull/7628/files#r1642315631, Let's merge this. |
…ands This patch adds `--target-rbconfig` option to specify the rbconfig.rb file for the deployment target platform. This is useful when cross-compiling gems. At the moment, this option is only available for `extconf.rb`-based extensions.
132178c to
07a5fae
Compare
| @@ -19,6 +19,10 @@ def run | |||
| # Disable color in deployment mode | |||
| Bundler.ui.shell = Thor::Shell::Basic.new if options[:deployment] | |||
|
|
|||
| if target_rbconfig_path = options[:"target-rbconfig"] | |||
| Bundler.rubygems.set_target_rbconfig(target_rbconfig_path) | |||
There was a problem hiding this comment.
This should probably fail more gracefully when the underlying RubyGems method is not available?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Today, CRuby runs on many platforms. But not all platforms are capable of running build tools (e.g. WebAssembly/WASI), so cross-target compilation against extensions libraries is essential for those platforms.
Currently, there is no way to cross-compile extension libraries in gems at install-time.
What is your fix for the problem, implemented in this PR?
This patch adds
--target-rbconfigoption to specify the rbconfig.rb file for the deployment target platform. It basically pass through it to mkmf. The underlying--target-rbconfigsupport in mkmf has been introduced recently https://bugs.ruby-lang.org/issues/20345At the moment, this option is only available when the following requirements are met:
extconf.rb-based extensionsBut we can relax the first requirement for Cargo builder by adding a support in rb-sys later.
$ GEM_HOME=/tmp/gems-wasm32-wasi gem install nokogiri --target-rbconfig path/to/wasm32-wasi/rbconfig.rbMake sure the following tasks are checked