8000 Bump rake version used by tests by deivid-rodriguez · Pull Request #7256 · rubygems/rubygems · GitHub
[go: up one dir, main page]
Skip to content

Bump rake version used by tests #7256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2023
Merged

Bump rake version used by tests #7256

merged 1 commit into from
Dec 12, 2023

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user or developer problem that led to this PR?

None, just keeping things up to date and making them easier to update in the future.

What is your fix for the problem, implemented in this PR?

Make it explicit that some tests depend on a specific version of rake being installed, and update that version.

Make sure the following tasks are checked

@deivid-rodriguez
Bump rake version used by tests
1ea4bfa 
And make it easier to update next time.
@deivid-rodriguez deivid-rodriguez merged commit 247e082 into master Dec 12, 2023
@deivid-rodriguez deivid-rodriguez deleted the bump-rake branch December 12, 2023 17:16
@k0kubun
Copy link
Contributor
k0kubun commented Dec 12, 2023

This failed ruby/ruby's make test-bundler-parallel https://github.com/ruby/ruby/actions/runs/7184961196/job/19567221887, despite "ruby-core / Bundler under a ruby-core setup" passing here.

Do you have any idea how we can fix this?

@deivid-rodriguez
Copy link
Member Author

Yeah! The automatic imported commit failed to import changes to tool/bundler files, so it's still using the old version. Those would need to be imported manually.

@deivid-rodriguez
Copy link
Member Author

ruby/ruby#9206 should fix it!

@k0kubun
Copy link
Contributor
k0kubun commented Dec 12, 2023

Thanks for the PR 👍

The automatic imported commit failed to import changes to tool/bundler files, so it's still using the old version. Those would need to be imported manually.

I just pushed ruby/ruby@fd7decb, hoping it will not happen next time.

@deivid-rodriguez
Copy link
Member Author

Yeah, I was just looking into that same fix! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segiddins segiddins segiddins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deivid-rodriguez @k0kubun @segiddins
0