8000 Support revocation with URL-encoded parameters by srook · Pull Request #656 · ruby-oauth/oauth2 · GitHub
[go: up one dir, main page]
Skip to content

Support revocation with URL-encoded parameters #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

Support revocation with URL-encoded parameters #656

merged 1 commit into from
Aug 6, 2025
+24 −11

Conversation

srook
Copy link
Contributor
@srook srook commented Aug 4, 2025

Fixes #655

@srook
Copy link
Contributor Author
srook commented Aug 4, 2025

@pboling can you please take a look? pipeline is failing but doesn't seem to be related to this PR?

@pboling
Copy link
Member
pboling commented Aug 4, 2025 •
edited
Loading

I'll fix that! It's because I released the appraisal2 gem and deleted the old fork branch this project had been relying on.

More here: https://dev.to/galtzo/ann-appraisal2-a-hard-fork-44dh

@pboling
Copy link
Member
pboling commented Aug 6, 2025 •
edited
Loading

CI is fixed in main! Please rebase @srook

@srook srook force-pushed the urlencoded-params-token-revocation branch from 97c009a to b9986a1 Compare August 6, 2025 08:34
@coveralls
Copy link
coveralls commented Aug 6, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 16771995951

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 16764643808: 0.0%
Covered Lines: 519
Relevant Lines: 519
💛 - Coveralls

@srook srook force-pushed the urlencoded-params-token-revocation branch from b9986a1 to dddc568 Compare August 6, 2025 08:42
@srook
Copy link
Contributor Author
srook commented Aug 6, 2025

thanks, but there still seems to be some issue with codecov, @pboling ?

@pboling
Copy link
Member
pboling commented Aug 6, 2025 •
edited
Loading

codecov/engineering-team#3594

I have filed several bugs with them. Their system is broken in a few ways, and we don't know yet how to get it working (again) in this repo.

For now we will ignore that.

@pboling pboling merged commit 7e2a392 into ruby-oauth:main Aug 6, 2025
35 of 36 checks passed
@pboling pboling mentioned this pull request Aug 6, 2025
Merged
@pboling pboling mentioned this pull request Aug 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pboling pboling pboling approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support form URL-encoded parameters for token revocation

3 participants

@srook @pboling @coveralls
0