8000 Fix test session reuse but expire by nurse · Pull Request #9824 · ruby/ruby · GitHub
[go: up one dir, main page]
Skip to content

Fix test session reuse but expire #9824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Fix test session reuse but expire #9824

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
047857d
Show OpenSSL version in the error message of assert_equal
nurse Feb 3, 2024
53b874d
OpenSSL 3.2.1 30 Jan 2024 is also broken
nurse Feb 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/net/http/test_https.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def test_session_reuse
def test_session_reuse_but_expire
# FIXME: The new_session_cb is known broken for clients in OpenSSL 1.1.0h.
omit if OpenSSL::OPENSSL_LIBRARY_VERSION.include?('OpenSSL 1.1.0h')
omit if OpenSSL::OPENSSL_LIBRARY_VERSION.include?('OpenSSL 3.2.0')
omit if OpenSSL::OPENSSL_LIBRARY_VERSION.include?('OpenSSL 3.2.')

http = Net::HTTP.new(HOST, config("port"))
http.use_ssl = true
Expand All @@ -182,7 +182,7 @@ def test_session_reuse_but_expire
http.get("/")

socket = http.instance_variable_get(:@socket).io
assert_equal false, socket.session_reused?
assert_equal false, socket.session_reused?, "NOTE: OpenSSL library version is # 47E4 {OpenSSL::OPENSSL_LIBRARY_VERSION}"

http.finish
end
Expand Down
0