Rewrite Array#each in Ruby using Primitive #9533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dca75f2 to
35f3b4e
Compare
|
Nice. Happy to see this working. Surprised it's so far in YJIT as well! Ideally, for YJIT, we'd like to be able to avoid doing a function call at all, so we can generate tight inlined code though, so we might need a specialized instruction instead of a cexpr? What do you think? |
I think it's possible without a new instruction. |
nobu
reviewed
Jan 17, 2024
nobu
reviewed
Jan 17, 2024
nobu
reviewed
Jan 17, 2024
3c97813 to
bede16a
Compare
bede16a to
3aaa6de
Compare
0d58851 to
4f30c21
Compare
4f30c21 to
6b5e44b
Compare
maximecb
reviewed
Jan 22, 2024
XrXr
approved these changes
Jan 23, 2024
2e2cd3f to
d98ac2c
Compare
paracycle
added a commit
to Shopify/sorbet
that referenced
this pull request
Feb 12, 2024
In order to provide compatibility with TruffleRuby that implements a lot of its core library methods in Ruby, and for future versions of CRuby that is increasingly doing the same, we need to be able to filter all backtrace locations where the `path` starts with `<internal:`. [This gist](https://gist.github.com/eregon/912e6359e83781c5fa1c638d3768c526) shows the current state of the methods implemented in Ruby in CRuby, JRuby and TruffleRuby. Most recently [CRuby started implementing `Array#each` in Ruby](ruby/ruby#9533), making it usages of `each` visible in backtraces with an `<internal:array>` path. This means that in order to be compatible with CRuby 3.4, Sorbet runtime needs to start filtering out backtrace locations that start with `<internal:`. By encapsulating the caller location search logic into a singleton method, we can apply that filtering in a single location and avoid having to repeat it in multiple places.
paracycle
added a commit
to Shopify/sorbet
that referenced
this pull request
Feb 12, 2024
In order to provide compatibility with TruffleRuby that implements a lot of its core library methods in Ruby, and for future versions of CRuby that is increasingly doing the same, we need to be able to filter all backtrace locations where the `path` starts with `<internal:`. [This gist](https://gist.github.com/eregon/912e6359e83781c5fa1c638d3768c526) shows the current state of the methods implemented in Ruby in CRuby, JRuby and TruffleRuby. Most recently [CRuby started implementing `Array#each` in Ruby](ruby/ruby#9533), making it usages of `each` visible in backtraces with an `<internal:array>` path. This means that in order to be compatible with CRuby 3.4, Sorbet runtime needs to start filtering out backtrace locations that start with `<internal:`. By encapsulating the caller location search logic into a singleton method, we can apply that filtering in a single location and avoid having to repeat it in multiple places.
paracycle
added a commit
to Shopify/sorbet
that referenced
this pull request
Feb 12, 2024
In order to provide compatibility with TruffleRuby that implements a lot of its core library methods in Ruby, and for future versions of CRuby that is increasingly doing the same, we need to be able to filter all backtrace locations where the `path` starts with `<internal:`. [This gist](https://gist.github.com/eregon/912e6359e83781c5fa1c638d3768c526) shows the current state of the methods implemented in Ruby in CRuby, JRuby and TruffleRuby. Most recently [CRuby started implementing `Array#each` in Ruby](ruby/ruby#9533), making it usages of `each` visible in backtraces with an `<internal:array>` path. This means that in order to be compatible with CRuby 3.4, Sorbet runtime needs to start filtering out backtrace locations that start with `<internal:`. By encapsulating the caller location search logic into a singleton method, we can apply that filtering in a single location and avoid having to repeat it in multiple places.
paracycle
added a commit
to Shopify/sorbet
that referenced
this pull request
Feb 12, 2024
In order to provide compatibility with TruffleRuby that implements a lot of its core library methods in Ruby, and for future versions of CRuby that is increasingly doing the same, we need to be able to filter all backtrace locations where the `path` starts with `<internal:`. [This gist](https://gist.github.com/eregon/912e6359e83781c5fa1c638d3768c526) shows the current state of the methods implemented in Ruby in CRuby, JRuby and TruffleRuby. Most recently [CRuby started implementing `Array#each` in Ruby](ruby/ruby#9533), making it usages of `each` visible in backtraces with an `<internal:array>` path. This means that in order to be compatible with CRuby 3.4, Sorbet runtime needs to start filtering out backtrace locations that start with `<internal:`. By encapsulating the caller location search logic into a singleton method, we can apply that filtering in a single location and avoid having to repeat it in multiple places.
neilparikh
pushed a commit
to sorbet/sorbet
that referenced
this pull request
Feb 13, 2024
In order to provide compatibility with TruffleRuby that implements a lot of its core library methods in Ruby, and for future versions of CRuby that is increasingly doing the same, we need to be able to filter all backtrace locations where the `path` starts with `<internal:`. [This gist](https://gist.github.com/eregon/912e6359e83781c5fa1c638d3768c526) shows the current state of the methods implemented in Ruby in CRuby, JRuby and TruffleRuby. Most recently [CRuby started implementing `Array#each` in Ruby](ruby/ruby#9533), making it usages of `each` visible in backtraces with an `<internal:array>` path. This means that in order to be compatible with CRuby 3.4, Sorbet runtime needs to start filtering out backtrace locations that start with `<internal:`. By encapsulating the caller location search logic into a singleton method, we can apply that filtering in a single location and avoid having to repeat it in multiple places.
neilparikh
pushed a commit
to sorbet/sorbet
that referenced
this pull request
Feb 14, 2024
In order to provide compatibility with TruffleRuby that implements a lot of its core library methods in Ruby, and for future versions of CRuby that is increasingly doing the same, we need to be able to filter all backtrace locations where the `path` starts with `<internal:`. [This gist](https://gist.github.com/eregon/912e6359e83781c5fa1c638d3768c526) shows the current state of the methods implemented in Ruby in CRuby, JRuby and TruffleRuby. Most recently [CRuby started implementing `Array#each` in Ruby](ruby/ruby#9533), making it usages of `each` 8000 visible in backtraces with an `<internal:array>` path. This means that in order to be compatible with CRuby 3.4, Sorbet runtime needs to start filtering out backtrace locations that start with `<internal:`. By encapsulating the caller location search logic into a singleton method, we can apply that filtering in a single location and avoid having to repeat it in multiple places.
paracycle
added a commit
to Shopify/sorbet
that referenced
this pull request
Feb 16, 2024
In order to provide compatibility with TruffleRuby that implements a lot of its core library methods in Ruby, and for future versions of CRuby that is increasingly doing the same, we need to be able to filter all backtrace locations where the `path` starts with `<internal:`. [This gist](https://gist.github.com/eregon/912e6359e83781c5fa1c638d3768c526) shows the current state of the methods implemented in Ruby in CRuby, JRuby and TruffleRuby. Most recently [CRuby started implementing `Array#each` in Ruby](ruby/ruby#9533), making it usages of `each` visible in backtraces with an `<internal:array>` path. This means that in order to be compatible with CRuby 3.4, Sorbet runtime needs to start filtering out backtrace locations that start with `<internal:`. By encapsulating the caller location search logic into a singleton method, we can apply that filtering in a single location and avoid having to repeat it in multiple places.
jez
pushed a commit
to sorbet/sorbet
that referenced
this pull request
Feb 21, 2024
In order to provide compatibility with TruffleRuby that implements a lot of its core library methods in Ruby, and for future versions of CRuby that is increasingly doing the same, we need to be able to filter all backtrace locations where the `path` starts with `<internal:`. [This gist](https://gist.github.com/eregon/912e6359e83781c5fa1c638d3768c526) shows the current state of the methods implemented in Ruby in CRuby, JRuby and TruffleRuby. Most recently [CRuby started implementing `Array#each` in Ruby](ruby/ruby#9533), making it usages of `each` visible in backtraces with an `<internal:array>` path. This means that in order to be compatible with CRuby 3.4, Sorbet runtime needs to start filtering out backtrace locations that start with `<internal:`. By encapsulating the caller location search logic into a singleton method, we can apply that filtering in a single location and avoid having to repeat it in multiple places.
jez
pushed a commit
to sorbet/sorbet
that referenced
this pull request
Feb 21, 2024
) In order to provide compatibility with TruffleRuby that implements a lot of its core library methods in Ruby, and for future versions of CRuby that is increasingly doing the same, we need to be able to filter all backtrace locations where the `path` starts with `<internal:`. [This gist](https://gist.github.com/eregon/912e6359e83781c5fa1c638d3768c526) shows the current state of the methods implemented in Ruby in CRuby, JRuby and TruffleRuby. Most recently [CRuby started implementing `Array#each` in Ruby](ruby/ruby#9533), making it usages of `each` visible in backtraces with an `<internal:array>` path. This means that in order to be compatible with CRuby 3.4, Sorbet runtime needs to start filtering out backtrace locations that start with `<internal:`. By encapsulating the caller location search logic into a singleton method, we can apply that filtering in a single location and avoid having to repeat it in multiple places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #6687, but race condition-free.
microbenchmark
Interpreter
Thanks to
Primitive, the interpreter doesn't slow down.YJIT
Even faster than #6687.
yjit-bench
See #9622.