Use max_cpu when RUBY_MAX_CPU given #9399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobu
reviewed
Dec 31, 2023
Comment on lines
-1688
to
+1692
| if (USE_MN_THREADS && max_cpu_cstr && (max_cpu = atoi(max_cpu_cstr)) > 0) { | ||
| max_cpu = default_max_cpu; | ||
| if (USE_MN_THREADS && max_cpu_cstr) { | ||
| int given_max_cpu = atoi(max_cpu_cstr); | ||
| if (given_max_cpu > 0) { | ||
| max_cpu = given_max_cpu; | ||
| } |
There was a problem hiding this comment.
Probably (max_cpu = atoi(max_cpu_cstr)) <= 0) was intended, I guess.
There was a problem hiding this comment.
just remove = default_max_cpu is intended. But @riseshia san's patch is more readable.
|
Thank you! |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy new year!!
From Ruby 3.3.0, M:N Thread introduced, and users can set how many CPU can be used for it via
RUBY_MAX_CPU.When user gives max cpu num for M:N thread via
RUBY_MAX_CPUenv, however, current implementation set value tomax_cpuand overwrite it withdefault_max_cpu.I think which is weird, and expected behavior is like this diff, set given max cpu num.
How do you think @ko1 ? Am I misunderstanding something? 🤔
Confirmed on custom build with this patch, and I noticed RUBY_MAX_CPU=1 make process unreachable, do we ignore if 1 given?