[DOC] RDoc for Complex #9260
8000
Jump to bottom
Merged
[DOC] RDoc for Complex #9260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
complex.c
Outdated
| * Complex(Rational(n.real, d), Rational(n.imag, d)) | ||
| * #=> ((1/2)+(2/3)*i) | ||
| * See denominator. | ||
| * Related: Complex.denominator. |
There was a problem hiding this comment.
Did you mean Complex#denominator?
Suggested change
| * Related: Complex.denominator. | |
| * Related: Complex#denominator. |
complex.c
Outdated
Comment on lines
1508
to
1521
| * This result is computed thus: | ||
| * | ||
| * 1 2 3+4i <- numerator | ||
| * - + -i -> ---- | ||
| * 2 3 6 <- denominator | ||
| * # Numerators and denominators for c.real and c.imag. | ||
| * c.real.numerator # => 2 | ||
| * c.real.denominator # => 3 | ||
| * c.imag.numerator # => 3 | ||
| * c.imag.denominator # => 4 | ||
| * # Real and imaginary parts for new Complex c.numerator. | ||
| * result_real = c.real.numerator * c.imag.denominator # => 8 | ||
| * result_imag = c.imag.numerator * c.real.denominator # => 9 | ||
| * # New Complex c.numerator (Q.E.D.). | ||
| * result = Complex(result_real, result_imag) # => (8+9i) | ||
| * c.numerator # => (8+9i) | ||
| * |
There was a problem hiding this comment.
I find this example to be difficult to understand. Can we explain using words instead? I think the numerator is the Complex created from the numerators of the real and imaginary parts after converting them to the least common denominator.
peterzhu2118
approved these changes
Dec 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#numerator and #denominator.