8000 Run nmake check on Actions by k0kubun · Pull Request #4487 · ruby/ruby · GitHub
[go: up one dir, main page]
Skip to content

Run nmake check on Actions #4487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 11, 2021
Merged

Run nmake check on Actions #4487

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9c6987e
Run nmake check on Actions
k0kubun May 11, 2021
5490814
Merge remote-tracking branch 'origin/master' into mswin-actions
k0kubun May 11, 2021
544d257
Skip tests not working in mswin GitHub Actions
k0kubun May 11, 2021
75feeef
Merge remote-tracking branch 'origin/master' into mswin-actions
k0kubun May 11, 2021
34150ea
Merge remote-tracking branch 'origin/master' into mswin-actions
k0kubun May 11, 2021
8f0dc01
Override TEMP
k0kubun May 11, 2021
e1f8ad7
Revert "Skip tests not working in mswin GitHub Actions"
k0kubun May 11, 2021
fae5863
Revert "Revert "Skip tests not working in mswin GitHub Actions""
k0kubun May 11, 2021
ab461dd
Fix timeouts
k0kubun May 11, 2021
f67b66c
Skip some more broken tests
k0kubun May 11, 2021
bc9694b
Update windows.yml
k0kubun May 11, 2021
3823e47
Add a guard for rbasic_spec
k0kubun May 11, 2021
e893b6e
Revert "Update windows.yml"
k0kubun May 11, 2021
2c071e2
Skip the ensure clause
k0kubun May 11, 2021
636d75b
Simplify the ensure
k0kubun May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Simplify the ensure
  • Loading branch information
@k0kubun
k0kubun committed May 11, 2021
commit 636d75b6fe49b66fc53d101978563a30ce68aead
3 changes: 1 addition & 2 deletions test/rubygems/test_gem_ext_builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ def test_build_extensions_with_gemhome_with_space
end

def test_build_extensions_install_ext_only
skip if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning
class << Gem
alias orig_install_extension_in_lib install_extension_in_lib

Expand All @@ -164,6 +163,7 @@ def Gem.install_extension_in_lib
false
end
end
skip if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning

@spec.extensions << 'ext/extconf.rb'

Expand Down Expand Up @@ -198,7 +198,6 @@ def Gem.install_extension_in_lib
refute_path_exists File.join @spec.gem_dir, 'lib', 'a.rb'
refute_path_exists File.join @spec.gem_dir, 'lib', 'a', 'b.rb'
ensure
return if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning
class << Gem
remove_method :install_extension_in_lib

Expand Down
0