8000 Make ERB::Util.html_escape reuse CGI.escapeHTML by spastorino · Pull Request #156 · ruby/ruby · GitHub
[go: up one dir, main page]
Skip to content

Make ERB::Util.html_escape reuse CGI.escapeHTML #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make ERB::Util.html_escape reuse CGI.escapeHTML #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/erb.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,6 +896,16 @@ class ERB
# A utility module for conversion routines, often handy in HTML generation.
module Util
public

# The set of special characters and their escaped values
TABLE_FOR_ESCAPE_HTML__ = {
"'" => ''',
'&' => '&',
'"' => '"',
'<' => '&lt;',
'>' => '&gt;',
}

#
# A utility method for escaping HTML tag characters in _s_.
#
Expand All @@ -909,7 +919,7 @@ module Util
# is a &gt; 0 &amp; a &lt; 10?
#
def html_escape(s)
s.to_s.gsub(/&/, "&amp;").gsub(/\"/, "&quot;").gsub(/>/, "&gt;").gsub(/</, "&lt;")
s.to_s.gsub(/['&\"<>]/, TABLE_FOR_ESCAPE_HTML__)
end
alias h html_escape
module_function :h
Expand Down
0