8000 Set O_BINARY correctly at rb_io_eof() by YO4 · Pull Request #14810 · ruby/ruby · GitHub
[go: up one dir, main page]
Skip to content

Set O_BINARY correctly at rb_io_eof() #14810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set O_BINARY correctly at rb_io_eof() #14810

wants to merge 1 commit into from
+24 −2

Conversation

YO4
Copy link
Contributor
@YO4 YO4 commented Oct 10, 2025

On Windows, when IO opend with “rt” it gives O_TEXT to fd. At this point calling io_fillbuf() causes a inconsistency between the read length and file position when encountering 0x1A (EOF)

Set O_BINARY correctly or use eof() under appropriate conditions.

fixes Bug #21634

@YO4
Set O_BINARY correctly at rb_io_eof()
ec7fbf1 
On Windows, when IO opend with “rt” it gives O_TEXT to fd.
At this point calling io_fillbuf() causes a inconsistency between the read length and file position when encountering 0x1A (EOF)

Set O_BINARY correctly or use eof() under appropriate conditions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@YO4
0