ZJIT: Inline well-known C functions into HIR #14679
Open
+122
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4fafe7e to
34d9eaf
Compare
k0kubun
approved these changes
Oct 1, 2025
XrXr
reviewed
Oct 2, 2025
|
|
||
| fn inline_kernel_itself(_fun: &mut hir::Function, _block: hir::BlockId, recv: hir::InsnId, args: &[hir::InsnId], _state: hir::InsnId) -> Option<hir::InsnId> { | ||
| if args.len() == 0 { | ||
| // No need to coerce the receiver; that is done by the SendWithoutBlock rewriting. |
There was a problem hiding this comment.
Suggested change
| // No need to coerce the receiver; that is done by the SendWithoutBlock rewriting. |
itself doesn't do any coercion in any caes
There was a problem hiding this comment.
In this case it does; it's a guard that the lhs is the expected type so that we can continue to inline the same method on it
Add the ability to create a Rust function that "open-codes" HIR implementations of specific well-known C functions, starting with `String#to_s`. It supports emitting multiple instructions into a temporary block, but does not support emitting *new blocks* (yet?).
34d9eaf to
a6224a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to create a Rust function that "open-codes" HIR
implementations of specific well-known C functions, starting with
String#to_s. It supports emitting multiple instructions into atemporary block, but does not support emitting new blocks (yet?).