8000 Introduce Array#values by MatheusRich · Pull Request #14641 · ruby/ruby · GitHub
[go: up one dir, main page]
Skip to content

Introduce Array#values #14641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Introduce Array#values #14641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions array.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3874,6 +3874,24 @@ rb_ary_values_at(int argc, VALUE *argv, VALUE ary)
return result;
}

/*
* call-seq:
* values -> new_array
*
* Retuns a new array with a shallow copy of the elements of +self+.
*/

static VALUE
rb_ary_values(VALUE ary)
{
long len = RARRAY_LEN(ary);
VALUE new_ary = rb_ary_new_capa(len);

if (len > 0) {
rb_ary_cat(new_ary, RARRAY_CONST_PTR(ary), len);
}
return new_ary;
}

/*
* call-seq:
Expand Down Expand Up @@ -8668,6 +8686,7 @@ rb_ary_deconstruct(VALUE ary)
* - #take_while: Returns leading elements as determined by a given block.
* - #uniq: Returns an array containing non-duplicate elements.
* - #values_at: Returns the elements at given offsets.
* - #values: Returns +self+. Helpful for compatibility with Hash#values.
*
* === Methods for Assigning
*
Expand Down Expand Up @@ -8823,6 +8842,7 @@ Init_Array(void)
rb_define_method(rb_cArray, "filter!", rb_ary_select_bang, 0);
rb_define_method(rb_cArray, "keep_if", rb_ary_keep_if, 0);
rb_define_method(rb_cArray, "values_at", rb_ary_values_at, -1);
rb_define_method(rb_cArray, "values", rb_ary_values, 0);
rb_define_method(rb_cArray, "delete", rb_ary_delete, 1);
rb_define_method(rb_cArray, "delete_at", rb_ary_delete_at_m, 1);
rb_define_method(rb_cArray, "delete_if", rb_ary_delete_if, 0);
Expand Down
11 changes: 11 additions & 0 deletions test/ruby/test_array.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3584,6 +3584,17 @@ def test_array_safely_modified_by_sort_block
assert_equal((1..67).to_a.reverse, var_0)
end

def test_values_returns_a_new_array_containing_a_shallow_copy_of_its_values
arr = []
array = [:a, arr]

values = array.values

assert_equal(array, values)
refute_same(array, values)
assert_same(arr, values[1])
end

private
def need_continuation
unless respond_to?(:callcc, true)
Expand Down
Loading
0