ZJIT: Add codegen (and FrameState) for GetConstPath #13628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
reviewed
Jun 16, 2025
| } | ||
|
|
||
| // Save PC since the call can allocate an IC | ||
| gen_save_pc(asm, state); |
k0kubun
approved these changes
Jun 16, 2025
tekknolagi
approved these changes
Jun 16, 2025
test/ruby/test_zjit.rb
Outdated
| Object.autoload(:X, #{File.realpath(autoload_path).inspect}) | ||
| def test = X | ||
| test | ||
| }, call_threshold: 1 |
There was a problem hiding this comment.
insns: [:opt_getconstant_path]?
Issue a call to rb_vm_opt_getconstant_path() like the interpreter, but since that allocates the IC, we need to save the PC before calling. Add FrameState to GetConstPath to get access to the PC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestio
2B0F
ns cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue a call to rb_vm_opt_getconstant_path() like the
interpreter, but since that allocates the IC, we need to save the PC
before calling. To have the PC, GetConstPath now has a FrameState.
Fixes: Shopify#586