8000 shape.h: make RSHAPE static inline by casperisfine · Pull Request #13596 · ruby/ruby · GitHub
[go: up one dir, main page]
Skip to content

shape.h: make RSHAPE static inline #13596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 12, 2025
Merged

shape.h: make RSHAPE static inline #13596

merged 4 commits into from
Jun 12, 2025

Conversation

casperisfine
Copy link
Contributor

Since the shape_tree_ptr is extern it should be possible to fully inline RSHAPE.

@launchable-app Launchable app
Copy link
launchable-app bot commented Jun 12, 2025 •
edited
Loading

❌ Tests Failed

✖️no tests failed ✔️61984 tests passed(3 flakes)

byroot added 2 commits June 12, 2025 15:00
@byroot
shape.h: make RSHAPE static inline
d3e817d 
Since the shape_tree_ptr is `extern` it should be possible to
fully inline `RSHAPE`.
@byroot
Get rid of rb_shape_lookup
5155458
byroot added 2 commits June 12, 2025 15:15
@byroot
Get rid of GET_SHAPE_TREE()
841c576 
It's a useless indirection.
@byroot
Allocate rb_shape_tree statically
ec9ad1e 
There is no point allocating it during init, it adds
a useless indirection.
@byroot byroot enabled auto-merge (rebase) June 12, 2025 14:38
@byroot byroot merged commit 7c22330 into ruby:master Jun 12, 2025
85 of 87 checks passed
635F
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casperisfine @byroot
0