8000 Fix RubyVM::Shape.transition_tree by etiennebarrie · Pull Request #13578 · ruby/ruby · GitHub
[go: up one dir, main page]
Skip to content

Fix RubyVM::Shape.transition_tree #13578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

Fix RubyVM::Shape.transition_tree #13578

merged 1 commit into from
Jun 10, 2025

Conversation

etiennebarrie
Copy link
Contributor

It's been broken since 3.3.0, a bisect points to 7c307e0 which seems to match.

@byroot
Copy link
Member
byroot commented Jun 10, 2025

It's weird, CI fail on some syntax error but I can't see it:

 ../src/shape.c: In function ‘edges’:
../src/shape.c:1402:5: warning: no return statement in function returning non-void [-Wreturn-type]
 1402 |     }
      |     ^
../src/shape.c: At top level:
../src/shape.c:1403:5: error: expected identifier or ‘(’ before ‘return’
 1403 |     return hash;
      |     ^~~~~~
../src/shape.c:1404:1: error: expected identifier or ‘(’ before ‘}’ token
 1404 | }
      | ^

byroot
byroot reviewed Jun 10, 2025
View reviewed changes
@etiennebarrie etiennebarrie force-pushed the fix-rubyvm-shape-transition-tree branch from 1812cb1 to c1589f2 Compare June 10, 2025 16:34
@byroot byroot enabled auto-merge (rebase) June 10, 2025 17:00
@byroot byroot merged commit c54e96d into ruby:master Jun 10, 2025
82 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byroot byroot byroot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etiennebarrie @byroot
0