8000 Launchable cleanup by nobu · Pull Request #13538 · ruby/ruby · GitHub
[go: up one dir, main page]
Skip to content

Launchable cleanup #13538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025
Merged

Launchable cleanup #13538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07aa887
CI: Split cleanups of Launchable generated files
nobu Jun 6, 2025
996ebf5
CI: Continue without record if Launchable setup failed
nobu Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/actions/compilers/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,12 @@ if [ "$LAUNCHABLE_ENABLED" = "true" ]; then
btest_session_file='launchable_btest_session.txt'
test_spec_session_file='launchable_test_spec_session.txt'
setup_launchable & setup_pid=$!
(sleep 180; kill "$setup_pid" 2> /dev/null) & sleep_pid=$!
wait -f "$setup_pid"
(sleep 180; echo "setup_launchable timed out; killing"; kill "$setup_pid" 2> /dev/null) & sleep_pid=$!
launchable_failed=false
wait -f "$setup_pid" || launchable_failed=true
kill "$sleep_pid" 2> /dev/null
echo "::endgroup::"
trap launchable_record_test EXIT
$launchable_failed || trap launchable_record_test EXIT
fi

pushd ${builddir}
Expand Down
42 changes: 33 additions & 9 deletions .github/actions/launchable/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ runs:
if: steps.enable-launchable.outputs.enable-launchable && startsWith(inputs.os, 'macos')

- name: Set up Launchable
id: setup-launchable
shell: bash
working-directory: ${{ inputs.srcdir }}
run: |
Expand Down Expand Up @@ -235,6 +236,38 @@ runs:
btest_report_file: ${{ steps.global.outputs.btest_report_file }}
test_spec_report_dir: ${{ steps.global.outputs.test_spec_report_dir }}

- name: Clean up session files in Launchable
uses: gacts/run-and-post-run@674528335da98a7afc80915ff2b4b860a0b3553a # v1.4.0
with:
shell: bash
working-directory: ${{ inputs.srcdir }}
post: |
rm -f "${test_all_session_file}"
rm -f "${btest_session_file}"
rm -f "${test_spec_session_file}
if: always() && steps.setup-launchable.outcome == 'success'
env:
test_all_session_file: ${{ steps.global.outputs.test_all_session_file }}
btest_session_file: ${{ steps.global.outputs.btest_session_file }}
test_spec_session_file: ${{ steps.global.outputs.test_spec_session_file }}

- name: Clean up test results in Launchable
uses: gacts/run-and-post-run@674528335da98a7afc80915ff2b4b860a0b3553a # v1.4.0
with:
shell: bash
working-directory: ${{ inputs.builddir }}
post: |
rm -f "${test_all_report_file}"
rm -f "${btest_report_file}"
rm -fr "${test_spec_report_dir}"
rm -f launchable_stdout.log
rm -f launchable_stderr.log
if: always() && steps.setup-launchable.outcome == 'success'
env:
test_all_report_file: ${{ steps.global.outputs.test_all_report_file }}
btest_report_file: ${{ steps.global.outputs.btest_report_file }}
test_spec_report_dir: ${{ steps.global.outputs.test_spec_report_dir }}

- name: Variables to report Launchable
id: variables
shell: bash
Expand Down Expand Up @@ -311,15 +344,6 @@ runs:
--session "$(cat "${test_spec_session_file}")" \
raw ${test_spec_report_path}/* || true; \
fi

rm -f "${test_all_session_file}"
rm -f "${btest_session_file}"
rm -f "${test_spec_session_file}"
rm -f "${test_report_path}"
rm -f "${btest_report_path}"
rm -fr "${test_spec_report_path}"
rm -f "${stdout_report_path}"
rm -f "${stderr_report_path}"
if: ${{ always() && steps.enable-launchable.outputs.enable-launchable }}
env:
test_report_path: ${{ steps.variables.outputs.test_report_path }}
Expand Down
Loading
0