Add String#ensure_suffix
#13366
Open
Add String#ensure_suffix
#13366
+33
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatheusRich
commented
May 16, 2025
| { | ||
| if (rb_str_end_with(1, &suffix, str)) return str; | ||
|
|
||
| return rb_str_plus(str, suffix); |
There was a problem hiding this comment.
I've used + here because I don't know if it is possible or desirable to use string interpolation in this case.
nobu
reviewed
May 18, 2025
eb09c75 to
e7a1f11
Compare
Returns a new string with the given suffix appended if not present, or a
duplicate of self if it already ends with suffix.
"Hell".ensure_suffix("o!") # => "Hello!"
"Hello!".ensure_suffix("o!") # => "Hello!"
e7a1f11 to
e7b9e36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns a new string 8000 with the given suffix appended if not present, or a
duplicate of self if it already ends with suffix.
In my microbenchmarks, writing it in C seems to be faster than in Ruby, but happy to change the implementation if the team prefers that.
Discussion: https://bugs.ruby-lang.org/issues/21346