8000 Fix `remove_instance_variable` on complex objects by byroot · Pull Request #13280 · ruby/ruby · GitHub
[go: up one dir, main page]
Skip to content

Fix remove_instance_variable on complex objects #13280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

Fix remove_instance_variable on complex objects #13280

merged 1 commit into from
May 8, 2025

Conversation

byroot
Copy link
Member
@byroot byroot commented May 8, 2025

Introduced in: #13159

Now that there is no longer a unique TOO_COMPLEX shape with no children, checking shape->type == TOO_COMPLEX is incorrect.

@byroot
Fix remove_instance_variable on complex objects
19afee5 
Introduced in: ruby#13159

Now that there is no longer a unique TOO_COMPLEX shape with
no children, checking `shape->type == TOO_COMPLEX` is incorrect.
jhawthorn
jhawthorn approved these changes May 8, 2025
View reviewed changes
Copy link
Member
@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these are all the cases of the == SHAPE_OBJ_TOO_COMPLEX pattern 👍

@byroot byroot merged commit b67711b into ruby:master May 8, 2025
84 checks passed
@byroot byroot deleted the shape-remove-ivar-too-complex branch May 8, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhawthorn jhawthorn jhawthorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byroot @jhawthorn
0