Avoid some false positive bundled gem warnings #12786
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df07295 to
c819aef
Compare
❌ Tests Failed✖️no tests failed ✔️61956 tests passed(37 flakes) |
c819aef to
5a7392d
Compare
When a bundled gem has already been removed, a `require` caller is rescuing `LoadError`, no warning/error messages should be displayed. Instead, let the bundled gem message be part of `LoadError`, so that it's not displayed when rescued, but still gets to the user when not rescued.
5a7392d to
37a4551
Compare
|
This still feels like a small usability improvement to me, even if it does not fix all issues. Thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a bundled gem has already been removed, a
requirecaller is rescuingLoadError, no warning/error messages should be displayed.Instead, let the bundled gem message be part of
LoadError, so that it's not displayed when rescued, but still gets to the user when not rescued.This is an idea to reintroduce #11550, but without the issue that made @hsbt revert the original approach: If users upgrade Ruby from a version that did not show any warnings, to a version where the default gem has already been removed, then they'll miss any noticed about removal of the default gem. By making the notice part of the
LoadError, they will not miss it.