[DOC] Tweaks to Array.try_convert #11260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
- Adds an introductory overview statement.
- Simplifies "case" cascade (if, otherwise, otherwise).
nobu
reviewed
Jul 28, 2024
array.c
Outdated
Comment on lines
1022
to
1023
| * - Otherwise if +object+ responds to <tt>:to_ary</tt>, | ||
| * returns <tt>object.to_ary</tt>. |
Member
There was a problem hiding this comment.
This may be worth to mention, that a TypeError is raised if the result of object.to_ary is neither an Array nor nil.
array.c
Outdated
| * Returns +nil+ if +object+ does not respond to <tt>:to_ary</tt> | ||
| * | ||
| * Raises an exception unless <tt>object.to_ary</tt> returns an +Array+ object. | ||
| * Raises TypeError unless <tt>object.to_ary</tt> returns an +Array+ object or +nil+. |
Member
There was a problem hiding this comment.
I think we should move this under the second bullet point since object could be an array or nil, then the return value of object.to_ary is never checked.
peterzhu2118
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.