8000 YJIT: Allow dev_nodebug to disasm release-mode code by k0kubun · Pull Request #11198 · ruby/ruby · GitHub
[go: up one dir, main page]
Skip to content

YJIT: Allow dev_nodebug to disasm release-mode code #11198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2024
Merged

YJIT: Allow dev_nodebug to disasm release-mode code #11198

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e57662
YJIT: Allow dev_nodebug to disasm release-mode code
k0kubun Jul 18, 2024
2b45a33
Revert "YJIT: Squash canary before falling back"
XrXr Jul 18, 2024
b9529a1
s/runtime_assertions/runtime_checks/
k0kubun Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "YJIT: Squash canary before falling back" 
This reverts commit f05ad37.
The stray canary issue should have been solved by
def7023, alleviating this codegen
accommodation.
  • Loading branch information
@XrXr
XrXr committed Jul 18, 2024
commit 2b45a336bf5f7fab77d34802682f40b1d7eb083e
6 changes: 0 additions & 6 deletions yjit/src/codegen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8385,12 +8385,6 @@ fn gen_send_dynamic<F: Fn(&mut Assembler) -> Opnd>(
// Save PC and SP to prepare for dynamic dispatch
jit_prepare_non_leaf_call(jit, asm);

// Squash stack canary that might be left over from elsewhere
assert_eq!(false, asm.get_leaf_ccall());
if cfg!(debug_assertions) {
asm.store(asm.ctx.sp_opnd(0), 0.into());
}

// Dispatch a method
let ret = vm_sendish(asm);

Expand Down
0