10000 YJIT: A64: Use ADDS/SUBS/CMP (immediate) when possible by XrXr · Pull Request #10402 · ruby/ruby · GitHub
[go: up one dir, main page]
Skip to content

YJIT: A64: Use ADDS/SUBS/CMP (immediate) when possible #10402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2024
Merged

YJIT: A64: Use ADDS/SUBS/CMP (immediate) when possible #10402

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11e2f63
YJIT: A64: Use ADDS/SUBS/CMP (immediate) when possible
XrXr Mar 28, 2024
f96e057
YJIT: A64: Split asm.mul() with immediates properly
XrXr Mar 28, 2024
b7523ea
Merge branch 'master' into yjit-a64-add-one
maximecb Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
YJIT: A64: Split asm.mul() with immediates properly 
There is in fact no MUL on A64 that takes an immediate, so this
instruction was using the wrong split method. No current usages of this
form in YJIT.
  • Loading branch information
@XrXr
XrXr committed Mar 28, 2024
commit f96e057bee0b70f9e158e4d69cacc1bbead6870f
17 changes: 16 additions & 1 deletion yjit/src/backend/arm64/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ impl Assembler
},
Insn::Mul { left, right, .. } => {
let opnd0 = split_load_operand(asm, *left);
let opnd1 = split_shifted_immediate(asm, *right);
let opnd1 = split_load_operand(asm, *right);
asm.mul(opnd0, opnd1);
},
Insn::Test { left, right } => {
Expand Down Expand Up @@ -1724,4 +1724,19 @@ mod tests {
0x8: mov x1, x11
"});
}

#[test]
fn test_mul_with_immediate() {
let (mut asm, mut cb) = setup_asm();

let out = asm.mul(Opnd::Reg(TEMP_REGS[1]), 3.into());
asm.mov(Opnd::Reg(TEMP_REGS[0]), out);
asm.compile_with_num_regs(&mut cb, 2);

assert_disasm!(cb, "6b0080d22b7d0b9be1030baa", {"
0x0: mov x11, #3
0x4: mul x11, x9, x11
0x8: mov x1, x11
"});
}
}
0