8000 Fix error at Ruby CI by soutaro · Pull Request #2445 · ruby/rbs · GitHub
[go: up one dir, main page]
Skip to content

Fix error at Ruby CI #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 9, 2025
Merged

Fix error at Ruby CI #2445

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4c22784
Fix C23 syntax errors
soutaro May 2, 2025
c5a3a8a
Add rake task to compile without C23 extensions
soutaro May 7, 2025
9de9a01
Add CI job
soutaro May 8, 2025
0e8c41d
Fix header includes
soutaro May 8, 2025
eb440db
Add `rb_raise` call
soutaro May 8, 2025
ccdef8b
Fix `NullToken` definition
soutaro May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add CI job
  • Loading branch information
@soutaro
soutaro committed May 8, 2025
commit 9de9a0110f42b308035b3b321146bcaebdeaa726
28 changes: 28 additions & 0 deletions .github/workflows/ruby.yml
View file
Open in desktop
4570
Original file line number Diff line number Diff line change
Expand Up @@ -106,3 +106,31 @@ jobs:
- run: bundle exec rake test:valgrind
env:
RUBY_FREE_AT_EXIT: 1
C99_compile:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job compiles the extension without C23 extensions to ensure it compiles with C99 compilers.

To compile it with clang, not gcc, the macos platform is used.

runs-on: macos-latest
strategy:
fail-fast: false
matrix:
ruby: ['3.4', head]
steps:
- uses: actions/checkout@v4
- name: Install dependencies
run: |
brew install ruby-build
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler: none
- name: Set working directory as safe
run: git config --global --add safe.directory $(pwd)
- name: Update rubygems & bundler
run: |
ruby -v
gem update --system
- name: clang version
run: clang --version
- name: bin/setup
run: |
bin/setup
- run: bundle exec rake clean compile_c99

0