10000 Implement context validation on parse by ksss · Pull Request #2336 · ruby/rbs · GitHub
[go: up one dir, main page]
Skip to content

Implement context validation on parse #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Implement context validation on parse #2336

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
403cc42
Implement context validation on parse
ksss Mar 18, 2025
46ce98e
Remove context validation logic
ksss Mar 18, 2025
b86ce27
Deprecate `--[no-]exit-error-on-syntax-error` option
ksss Mar 18, 2025
824cfa0
Fix cli_test
ksss Mar 18, 2025
5e57af5
Remove RBS::WillSyntaxError
ksss Mar 18, 2025
792c889
Give up static analysis of `self`.
ksss Mar 18, 2025
530503e
Update doc
ksss Mar 19, 2025
55640d1
Support `self` in method
ksss Mar 24, 2025
c04a25b
Reimplement context validation on parse by struct
ksss May 22, 2025
2738467
Rename TypeValidation to rbs_type_validation_t to follow naming conve…
ksss May 22, 2025
d11b15d
Add test case for lower bound
ksss May 27, 2025
4f7e063
Rename type name
ksss May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Support self in method
  • Loading branch information
@ksss
ksss committed May 27, 2025
commit 55640d173e180738175bd3bb1cf0af91726e6e2c
6 changes: 3 additions & 3 deletions lib/rbs/prototype/rb.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,8 +372,8 @@ def process(node, decls:, comments:, context:)
end

value_node = node.children.last
type = if value_node.nil?
# Give up type prediction when node is MASGN.
type = if value_node.nil? || value_node.type == :SELF
# Give up type prediction when node is MASGN or SELF.
Types::Bases::Any.new(location: nil)
else
literal_to_type(value_node)
Expand Down Expand Up @@ -671,7 +671,7 @@ def literal_to_type(node)
BuiltinNames::Hash.instance_type(key_type, value_type)
end
when :SELF
Types::Bases::Any.new(location: nil)
Types::Bases::Self.new(location: nil)
when :CALL
receiver, method_name, * = node.children
case method_name
Expand Down
2 changes: 1 addition & 1 deletion test/rbs/rb_prototype_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def hash3: () -> { foo: { bar: 42 }, x: { y: untyped } }

def hash4: () -> ::Hash[:foo | untyped, 1 | untyped]

def self1: () -> untyped
def self1: () -> self
end
EOF
end
Expand Down
0