Fix TaskArguments#deconstruct_keys with keys = nil #635
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`#deconstruct_keys` should handle `keys == nil`, or `**rest` will be broken.
For example, the normal behavior looks like this:
```ruby
{a: 1, b: 2, c: 3} => {a:, **rest}
a # => 1
rest # => {b: 2, c: 3}
```
But without handling `keys == nil`, we'll get this:
```ruby
class Example
def initialize(hash) = @hash = hash
def deconstruct_keys(keys) = @hash.slice(*keys)
end
Example.new({a: 1, b: 2, c: 3}) => {a:, **rest}
# !> "#{inspect}: key not found: :a" (NoMatchingPatternKeyError)
```
rgarner
reviewed
Jun 2, 2025
test/test_rake_task_arguments.rb
Outdated
Comment on lines
61
to
62
| assert_equal ta.deconstruct_keys(nil), { a: 1, b: 2, c: 3 } | ||
| assert_equal ta.deconstruct_keys([:a, :b]), { a: 1, b: 2 } |
There was a problem hiding this comment.
Suggested change
| assert_equal ta.deconstruct_keys(nil), { a: 1, b: 2, c: 3 } | |
| assert_equal ta.deconstruct_keys([:a, :b]), { a: 1, b: 2 } | |
| assert_equal({ a: 1, b: 2, c: 3 }, ta.deconstruct_keys(nil)) | |
| assert_equal({ a: 1, b: 2 }, ta.deconstruct_keys([:a, :b])) |
Being an RSpec devotee, I spoke with an accent when I added this test and had the assert_equal(expected, actual) order backwards. It'd only affect the failure message but I'd hate for someone plugging a hole to copy my bad accent...
(I went to fix it but then noticed you'd opened this PR! Too quick for me 😉)
There was a problem hiding this comment.
I'm also an rspec guy, so I get the order of these backwards pretty often myself. I certainly didn't notice they were in the wrong order here! 😉 Anyway, I pushed an update with them in the correct order. Thanks. 🙂
Co-authored-by: Russell Garner <rgarner@zephyros-systems.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the initial implementation (#515):
#deconstruct_keysshould handlekeys == nil, or**restwill be broken.For example, the normal behavior looks like this:
But without handling
keys == nil, we'll get this: