8000 Make CSV::Row#dup return a usable Row by fastjames · Pull Request #108 · ruby/csv · GitHub
[go: up one dir, main page]
Skip to content

Make CSV::Row#dup return a usable Row #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2019
Merged

Make CSV::Row#dup return a usable Row #108

merged 2 commits into from
Oct 22, 2019

Conversation

fastjames
Copy link
Contributor

Previously, calling dup on a CSV::Row object yielded an object whose
copy was too shallow. Changing the clone's fields would also change the
fields on the source. This change makes the clone more distinct from the
source, so that changes can be made to its fields without affecting the
source.

fastjames and others added 2 commits October 21, 2019 21:14
@fastjames
Make CSV::Row#dup return a usable Row
9503291 
Previously, calling `dup` on a `CSV::Row` object yielded an object whose
copy was too shallow. Changing the clone's fields would also change the
fields on the source. This change makes the clone more distinct from the
source, so that changes can be made to its fields without affecting the
source.
@kou
Simplify
e09c1ee
@kou kou merged commit 64a1ea0 into ruby:master Oct 22, 2019
@kou
Copy link
Member
kou commented Oct 22, 2019

Thanks.
I've merged with simplified implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fastjames @kou
0